[tor-bugs] #2190 [Tor Client]: Possible reentrant calls to libevent from libevent logging callback

[Tor Bug Tracker & Wiki]

#2190: Possible reentrant calls to libevent from libevent logging callback
------------------------+---------------------------------------------------
 Reporter:  nickm       |       Owner:  rransom           
     Type:  defect      |      Status:  needs_review      
 Priority:  normal      |   Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |     Version:                    
 Keywords:              |      Parent:                    
------------------------+---------------------------------------------------

Comment(by rransom):

 Replying to [comment:6 cypherpunks]:
 > Because if no one can change pending_cb_messages during do{}while() the
 the last part is equal at least to:

 The call to `lf->callback` can change `pending_cb_messages`.  That's why
 he moved `pending_cb_messages` into a temporary variable `messages` and
 then put a new list in `pending_cb_messages`.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2190#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online