[tor-bugs] #1525 [Tor - Tor client]: RESOLVE control port command code path is incorrect

[Tor Bug Tracker & Wiki]

#1525: RESOLVE control port command code path is incorrect
------------------------------+---------------------------------------------
 Reporter:  mikeperry         |       Owner:  mwenge      
     Type:  defect            |      Status:  needs_review
 Priority:  minor             |   Milestone:              
Component:  Tor - Tor client  |     Version:              
 Keywords:                    |      Parent:              
------------------------------+---------------------------------------------

Comment(by Sebastian):

 The actual code changes look good, thanks!

 Here's some documentation comments:

 You should document the return value and arguments of
 connection_ap_rewrite_and_attach_if_allowed() (or point to
 connection_ap_handshake_rewrite_and_attach()'s documentation).

 Also generally, I think the documentation should be "unless a controller
 asked us to leave streams unattached" instead of "if the controller has
 asked us to take care of attaching streams to circuits".

 Another small issue is with the changes file. We like to end the text
 there with "Bugfix on <tor-release>; fixes bug <bugnumber>." so that
 people reading the changelog instead of the commit log have that
 information readily available.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1525#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online