[tor-bugs] #1746 [Tor - Relay]: Allow statistics options to be changed without restarting Tor

[Tor Bug Tracker & Wiki]

#1746: Allow statistics options to be changed without restarting Tor
-------------------------+--------------------------------------------------
 Reporter:  Sebastian    |       Owner:              
     Type:  defect       |      Status:  needs_review
 Priority:  normal       |   Milestone:              
Component:  Tor - Relay  |     Version:              
 Keywords:               |      Parent:              
-------------------------+--------------------------------------------------

Comment(by nickm):

 > We might further move the exit port statistics code in rephist.c after
 rep_hist_free_all() and before cell statistics. Should we do that as a
 separate commit logically preceding this patch?

 The order doesn't greatly matter, but adding another patch to clean up
 code would always be neat.

 > We don't collect data for more than 1 interval anymore, but only for
 complete 24 hour intervals

 This is a new change with this patch, or an old change?  And if it's a new
 change with this patch, what's the rationale?  (If it was an old change,
 do you remember why we did it?)

 > Should we separate the code refactoring parts from the bugfixing parts?

 In the future, yes: it's way easier to review a commit if you know "this
 commit isn't supposed to change functionality."  For this patch, it
 probably isn't necessary, since we've already been reviewing it.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1746#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online