[tor-bugs] #1746 [Tor - Relay]: Allow statistics options to be changed without restarting Tor
Tor Bug Tracker & Wiki
torproject-admin at torproject.org
Mon Aug 2 16:17:25 UTC 2010
#1746: Allow statistics options to be changed without restarting Tor
-------------------------+--------------------------------------------------
Reporter: Sebastian | Owner:
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: Tor - Relay | Version:
Keywords: | Parent:
-------------------------+--------------------------------------------------
Comment(by Sebastian):
Some comments on your notes:
* I think that's a good idea, but probably for a later patch. I was
aiming for that in my heartbeat work, but that got interrupted by
microdescriptors as an actual deliverable.
* per-country (or geoip or entrystatistics) (all mean the same thing, and
yes this is very confusing) seem to use the same behaviour as bridge
statistics now. Not sure if that is intended.
* The way we are "forgetting" geoip stats is that we re-initialize them
to be empty when they are enabled next time. This re-initialization sets
start_of_bridge_stats_interval in geoip.c to now, and in
geoip_bridge_stats_write() everything that was recoreded before
start_of_bridge_stats_interval gets removed. That does not look like
fantastic design, but should probably get cleaned up in a later patch.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1746#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list