[tbb-dev] [tor-packagers] torbrowser: problems with 9.0.1 source tarball

[Thomas Klausner]

On Mon, Dec 02, 2019 at 03:43:37PM +0100, Nicolas Vigier wrote:
> Hi!
> 
> I think the best list to discuss Tor Browser build problems is the
> tbb-dev at lists.torproject.org list, so I'm anwsering there.
> 
> On Fri, 15 Nov 2019, Thomas Klausner wrote:
> 
> > Hi!
> > 
> > I wanted to build firefox-tor-browser-68.2.0esr-9.0-1-build2
> > (torbrowser 9.0.1) on NetBSD from the source tarball, but I stumbled
> > over a couple problems.
> > 
> > The first one, .mozconfig contains --disable-eme but configure doesn't like it:
> > 
> > mozbuild.configure.options.InvalidOptionError: --disable-eme is not available in this configuration
> > 
> > Is this a NetBSD-specific issue or more general?
> 
> In our linux, windows, macOS .mozconfigs we have the line:
> 
>   ac_add_options --disable-eme
> 
> But I don't remember seeing this error, so it looks NetBSD-specific.

So where are the valid flags per OS defined?

> > The second one:
> > 
> > --- begin ---
> > The error occurred while processing the following file:
> > 
> >     /scratch/security/tor-browser/work/firefox-tor-browser-68.2.0esr-9.0-1-build2/browser/extensions/moz.build
> > 
> > The underlying problem is we referenced a path that does not exist. That path is:
> > 
> >     /scratch/security/tor-browser/work/firefox-tor-browser-68.2.0esr-9.0-1-build2/browser/extensions/tor-launcher/moz.build
> > 
> > Either create the file if it needs to exist or do not reference it.
> > --- end ---
> > 
> > 
> > The directory browser/extensions/tor-launcher does not exist in the
> > tarball, which looks like a problem with the tarball to me.
> 
> This is a change from this ticket:
> https://trac.torproject.org/projects/tor/ticket/28044
> 
> So you can either download tor-launcher, and extract it under
> browser/extensions, renaming the tor-launcher-$version directory to
> tor-launcher:
> https://dist.torproject.org/torbrowser/9.0.1/src-tor-launcher-0.2.20.2.tar.xz
> https://dist.torproject.org/torbrowser/9.0.1/src-tor-launcher-0.2.20.2.tar.xz.asc
> 
> Or you can build without tor-launcher by adding "ac_add_options --disable-tor-launcher" 
> to the .mozconfig.

What do you recommend? I'm unclear on what tor-launcher does.

Thanks,
 Thomas