[tbb-dev] trouble building tor-browser-bundle.git

[David Fifield]

On Fri, Apr 07, 2017 at 09:55:06PM -0700, Arthur D. Edelstein wrote:
> Thanks, David! Unfortunately I then ran into another problem, that
> looks like it might be caused by your workaround ("Failed to find an
> lxc-init"). Or maybe I didn't mimic what you did correctly? In any
> case, I'll try to investigate tomorrow.
> 
> Here's the part where it fails:
> 
> ****** Starting Utilities Component of Linux Bundle (1/7 for Linux) ******
> 
> --- Building utils-linux for wheezy i386 ---
> Stopping target if it is up
> Making a new image copy
> lxc-execute: Failed to find an lxc-init

I didn't get that error, but it's probably because I wasn't doing an LXC
build.

Maybe the file has to be in both places,
/usr/sbin/init.lxc and /usr/lib/lxc/lxc-init?
make-base-vm could check which one exists and copy it to the other.

Here is the patch I used BTW:

index 59f0734..f524991 100755
--- a/bin/make-base-vm
+++ b/bin/make-base-vm
@@ -161,6 +161,8 @@ if [ $LXC = "1" ]; then
   # Need universe for lxc in lucid
   env -i LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 sudo debootstrap --arch=$ARCH --include=$addpkg --exclude=$removepkg --components=$components $SUITE $OUT-bootstrap $MIRROR
   # Fix lxc issue
+  if [ ! -f $OUT-bootstrap/usr/sbin/init.lxc ]
+  then
   if [ -f $OUT-bootstrap/usr/lib/lxc/lxc-init ]
   then
     sudo cp $OUT-bootstrap/usr/lib/lxc/lxc-init $OUT-bootstrap/usr/sbin/init.lxc
@@ -172,6 +174,7 @@ if [ $LXC = "1" ]; then
       sudo cp $OUT-bootstrap/usr/lib/i386-linux-gnu/lxc/lxc-init $OUT-bootstrap/usr/sbin/init.lxc
     fi
   fi
+  fi
   dd if=/dev/zero of=$OUT-lxc bs=1M count=1 seek=15360
   /sbin/mkfs.ext4 -F $OUT-lxc
   t=`mktemp -d gitian.XXXXXXXX`