[tbb-commits] [Git][tpo/applications/tor-browser][base-browser-128.1.0esr-14.0-1] fixup! Bug 40925: Implemented the Security Level component

[morgan (@morgan)]

morgan pushed to branch base-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser


Commits:
a67e4520 by Henry Wilkes at 2024-08-07T22:50:45+00:00
fixup! Bug 40925: Implemented the Security Level component

Bug 42704: Drop the "badged" attribute from the security level button.

- - - - -


2 changed files:

- browser/components/securitylevel/content/securityLevel.js
- browser/components/securitylevel/content/securityLevelButton.inc.xhtml


Changes:

=====================================
browser/components/securitylevel/content/securityLevel.js
=====================================
@@ -69,7 +69,6 @@ var SecurityLevelButton = {
    * Open the panel popup for the button.
    */
   openPopup() {
-    let anchorNode;
     const overflowPanel = document.getElementById("widget-overflow");
     if (overflowPanel.contains(this._button)) {
       // We are in the overflow panel.
@@ -84,10 +83,8 @@ var SecurityLevelButton = {
       // panel rather than our dialog-like panel.
       overflowPanel.hidePopup();
       this._anchorButton = document.getElementById("nav-bar-overflow-button");
-      anchorNode = this._anchorButton.icon;
     } else {
       this._anchorButton = this._button;
-      anchorNode = this._button.badgeStack;
     }
 
     const panel = SecurityLevelPanel.panel;
@@ -103,7 +100,13 @@ var SecurityLevelButton = {
       });
     }
 
-    panel.openPopup(anchorNode, "bottomright topright", 0, 0, false);
+    panel.openPopup(
+      this._anchorButton.icon,
+      "bottomright topright",
+      0,
+      0,
+      false
+    );
   },
 
   init() {


=====================================
browser/components/securitylevel/content/securityLevelButton.inc.xhtml
=====================================
@@ -1,5 +1,4 @@
 <toolbarbutton id="security-level-button"
                class="toolbarbutton-1 chromeclass-toolbar-additional"
-               badged="true"
                removable="true"
                cui-areatype="toolbar"/>



View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a67e45205e4d10d076706b4821a4832785ec5c82

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a67e45205e4d10d076706b4821a4832785ec5c82
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tbb-commits/attachments/20240807/5552d0c4/attachment-0001.htm>