[tbb-commits] [Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 7494: Create local home page for TBB.

[Pier Angelo Vendrame (@pierov)]

Pier Angelo Vendrame pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser


Commits:
9506e131 by Henry Wilkes at 2024-08-07T10:21:51+01:00
fixup! Bug 7494: Create local home page for TBB.

Bug 42629: Add "about:tor" to `newTabUrls` instead of checking the
scheme and path individually.

- - - - -


1 changed file:

- browser/base/content/browser-places.js


Changes:

=====================================
browser/base/content/browser-places.js
=====================================
@@ -1409,14 +1409,6 @@ var BookmarkingUI = {
     if (!uri) {
       return false;
     }
-    // If uri is "about:tor" then we return true. See tor-browser#41717.
-    // NOTE: "about:newtab", "about:welcome", "about:home" and
-    // "about:privatebrowsing" can also redirect to "about:tor".
-    // NOTE: We do not simply add "about:tor" to newTabURLs below because this
-    // would also match "about:torconnect".
-    if (uri.scheme === "about" && uri.filePath === "tor") {
-      return true;
-    }
     // Prevent loading AboutNewTab.sys.mjs during startup path if it
     // is only the newTabURL getter we are interested in.
     let newTabURL = Cu.isESModuleLoaded(
@@ -1435,6 +1427,10 @@ var BookmarkingUI = {
       newTabURL,
       "about:home",
       "chrome://browser/content/blanktab.html",
+      // Add the "about:tor" uri. See tor-browser#41717.
+      // NOTE: "about:newtab", "about:welcome", "about:home" and
+      // "about:privatebrowsing" can also redirect to "about:tor".
+      "about:tor",
     ];
     if (PrivateBrowsingUtils.isWindowPrivate(window)) {
       newTabURLs.push("about:privatebrowsing");



View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/9506e131ab552bd82f0efbe722be83da7bcf124d

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/9506e131ab552bd82f0efbe722be83da7bcf124d
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tbb-commits/attachments/20240807/1ea97970/attachment-0001.htm>