[tbb-commits] [Git][tpo/applications/tor-browser][base-browser-102.11.0esr-12.0-1] 75 commits: Bug 1685403 - Use NS_GetFinalChannelURI at some places, r=necko-reviewers, valentin

Tue May 9 06:20:42 UTC 2023

Pier Angelo Vendrame pushed to branch base-browser-102.11.0esr-12.0-1 at The Tor Project / Applications / Tor Browser

Commits:
e5b1d877 by Kershaw Chang at 2023-05-08T10:37:40+02:00
Bug 1685403 - Use NS_GetFinalChannelURI at some places, r=necko-reviewers,valentin

Differential Revision: https://phabricator.services.mozilla.com/D164656
- - - - -
68f2b809 by Pier Angelo Vendrame at 2023-05-08T10:37:40+02:00
Bug 1774413: Bundled fonts are not picked up on macOS r=jfkthame

Bundled fonts were not picked up because also child processes need to
register them.
Also, they were assigned User visibility, instead of Base, which was
not coherent with other platforms.

Differential Revision: https://phabricator.services.mozilla.com/D150400
- - - - -
b498929c by Pier Angelo Vendrame at 2023-05-08T10:37:41+02:00
Bug 1769030: Add a configure flag to load policies only from the local policies.json file r=mkaply,glandium

Add a configuration flag to make Enterprise Policies mechanism only
consult a policies.json file (avoiding the Windows Registry, macOS's
file system attributes, and /etc/firefox/policies/policies.json on
other OS).

Differential Revision: https://phabricator.services.mozilla.com/D146300

- - - - -
a14e7402 by Jamie Nicol at 2023-05-08T10:37:41+02:00
Bug 1784588 - Fix SplitDriverVersion when the string has less than 4 numbers. r=aosmond

Differential Revision: https://phabricator.services.mozilla.com/D154897
- - - - -
fc9f76c2 by Pier Angelo Vendrame at 2023-05-08T10:37:42+02:00
Bug 1768907 - Part 1: Make browser.privatebrowsing.autostart a static pref. r=handyman,necko-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D157843

- - - - -
ff393146 by Neill Miller at 2023-05-08T10:37:42+02:00
Bug 1768907 - Part 2: nsTransferable disk-leaks when private browsing mode is enabled by default. r=handyman

nsTransferable was modified to prevent disk leakings when copying data
in private browsing mode with Bug 1123480.
However, the context is nullptr when it is initialized, so it still
leaks if PBM is enabled by default.
Our solution is to check the browser.privatebrowsing.autostart in this
condition.

Differential Revision: https://phabricator.services.mozilla.com/D157800
- - - - -
479be7a7 by Gabriele Svelto at 2023-05-08T10:37:42+02:00
Bug 1670885 - Fix post-fork() handlers for PHC/LogAlloc to work on macOS using unfair locks r=glandium

macOS unfair locks enforce that a lock can only be released by the thread which locked it.

On macOS 11+ this caused the fork()'d child process to raise a SIGILL signal. Confusingly enough this behavior seems to be different on macOS 10.15 and possibly interacted in odd ways with our exception handler if it was installed before fork()-ing.

Differential Revision: https://phabricator.services.mozilla.com/D148287
- - - - -
db215d32 by Gabriele Svelto at 2023-05-08T10:37:43+02:00
Bug 1670885 - Replace deprecated NSSpinLocks with os_unfair_locks in the memory allocator r=glandium

Depends on D148287

Differential Revision: https://phabricator.services.mozilla.com/D99280
- - - - -
7db9ec6c by Kathy Brade at 2023-05-08T11:00:48+02:00
Bug 1769028: Disable DNS lookup in nsProfileLock when the proxy bypass protection is enabled r=mossop

Instead of using the local computer's IP address within
symlink-based profile lock signatures, always use 127.0.0.1 when the
proxy bypass protection is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D161264
- - - - -
240c10c7 by Gabriele Svelto at 2023-05-08T11:00:57+02:00
Bug 1774458 - Use undocumented, non-public adaptive spinlocks on macOS 10.15+, revert to user-space spinlocks on older versions r=pbone

Differential Revision: https://phabricator.services.mozilla.com/D149599
- - - - -
698693b6 by Gabriele Svelto at 2023-05-08T11:00:57+02:00
Bug 1784018 - Remove deprecated OSSpinLocks r=glandium

On macOS versions prior to 10.15 os_unfair_locks cannot spin in kernel-space
which degrades performance significantly. To obviate for this we spin in
user-space like OSSpinLock does, for the same number of times and invoking
x86-specific pause instructions in-between the locking attempts to avoid
starving a thread that might be running on the same physical core.

Differential Revision: https://phabricator.services.mozilla.com/D154205
- - - - -
59afee38 by Hubert Boma Manilla at 2023-05-08T11:00:58+02:00
Bug 1790542 - [devtools] Do not allow redirects on the 'sourceMappingUrl' r=jdescottes,devtools-reviewers

- Block redirects on sourceMappingUrl
- Add debugger test

Differential Revision: https://phabricator.services.mozilla.com/D168648
- - - - -
cd2fcf2b by Hubert Boma Manilla at 2023-05-08T11:00:58+02:00
Bug 1790542 - [devtools] Convert browser_source_map-reload.js test from using .sjs files to createTestHTTPServer r=ochameau,devtools-reviewers

.sjs files depend on redirects to load static files.
In D168648 we block redirects on sourceMappingUrl, so this browser_source_map-reload.js
fails because we use .sjs to serve the content.

This patch refactors to no longer use .sjs files

Differential Revision: https://phabricator.services.mozilla.com/D169739

- - - - -
b0820bb4 by Rob Wu at 2023-05-08T11:00:59+02:00
Bug 1802385 - Use NS_GetFinalChannelURI in FetchDriver r=rpl,valentin

Depends on D164656

Differential Revision: https://phabricator.services.mozilla.com/D166108

- - - - -
a3a5cc08 by Kash Shampur at 2023-05-08T11:00:59+02:00
Bug 1803109 - Discard blocks of data that are too big for two chunks. r=canaltinova

Currently, `ReserveAndPutRaw` allocates a second span even if the data would be too big for the chunk.
Here a second conditional is added to check if the block of data is too big in this scenario and silently discard the data if so.

Differential Revision: https://phabricator.services.mozilla.com/D167167
- - - - -
871d06ca by Pier Angelo Vendrame at 2023-05-08T11:01:00+02:00
Bug 1814416: Generalize the app name in about:buildconfig. r=ahochheiden

Now it displays app display name, instead of having Firefox hardcoded.

Differential Revision: https://phabricator.services.mozilla.com/D168562
- - - - -
2f88a2bc by Jon Coppeard at 2023-05-08T11:01:00+02:00
Bug 1816158 - Part 1: Disallow GC while iterating global's debugger vector r=sfink

GC can mutate this vector so don't allow that while we are iterating. I think
it would be safe to use index-based iteration but it's safer to just ban it
entirely.

This fixes the crash produced by the testcase.

Differential Revision: https://phabricator.services.mozilla.com/D169701
- - - - -
e8465d3d by Jon Coppeard at 2023-05-08T11:01:00+02:00
Bug 1816158 - Part 2: Require no GC when giving out references to the realm's debugger vector r=sfink

To prevent any other instances of this problme we can update the getDebuggers()
methods on the global and the realm to require no GC.

Depends on D169701

Differential Revision: https://phabricator.services.mozilla.com/D169702

- - - - -
2eb5684d by Georg Koppen at 2023-05-08T11:01:01+02:00
Revert "Bug 1724777, optimize suppressed MicroTask handling, r=mccr8 a=RyanVM"

This reverts commit 1eb1364357ac5bc2a4531337fb5416af39c3793f.

This fixes tor-browser#40721, tor-browser#40698, and tor-browser#40706.
However, it is a temporary workaround, that we should revert once
https://bugzilla.mozilla.org/show_bug.cgi?id=1744719 is fixed.

- - - - -
013c0772 by Richard Pospesel at 2023-05-08T11:01:01+02:00
fixup! Bug 1761389 - Add and use new PDF-specific document icon on Windows. r=bhearsum

- - - - -
a7ab945a by Henry Wilkes at 2023-05-08T11:01:02+02:00
Bug 41454: Move focus after calling openPreferences for a sub-category.

Temporary fix until mozilla bug 1799153 gets a patch upstream.

- - - - -
6e9b7ba8 by Pier Angelo Vendrame at 2023-05-08T11:01:02+02:00
Bug 41116: Normalize system fonts.

System fonts are an enormous fingerprinting vector.
Even with font allow lists and with our custom configuration on Linux,
which counter metrics measurements, getComputedStyle leaks several
details.
This patch counters both these kinds of attacks.

- - - - -
d9567e9b by Pier Angelo Vendrame at 2023-05-08T11:01:02+02:00
Tweaks to the build system

Bug 40857: Modified the fat .aar creation file

This is a workaround to build fat .aars with the compiling enviornment
disabled.
Mozilla does not use a similar configuration, but either runs a Firefox
build and discards its output, or uses artifacts build.

We might switch to artifact builds too, and drop this patch, or write a
better one to upstream. But until then we need this patch.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770.

Bug 41458: Prevent `mach package-multi-locale` from actually creating a package

macOS builds need some files to be moved around with
./mach package-multi-locale to create multi-locale packages.
The required command isn't exposed through any other mach command.
So, we patch package-multi-locale both to prevent it from failing when
doing official builds and to detect any future changes on it.

- - - - -
a80054e2 by Dan Ballard at 2023-05-08T11:01:03+02:00
Bug 41117: using MOZ_PROXY_BYPASS_PROTECTION disable share menu on mac and windows, and restore email link on mac

- - - - -
57c78f8d by Gaba at 2023-05-08T11:01:03+02:00
Adding issue template for bugs.

- - - - -
d03e82d9 by Pier Angelo Vendrame at 2023-05-08T11:01:04+02:00
Base Browser's .mozconfigs.

- - - - -
a6c53089 by Pier Angelo Vendrame at 2023-05-08T11:01:04+02:00
Bug 41108: Remove privileged macOS installation from 102

- - - - -
88280b6b by Dan Ballard at 2023-05-08T11:01:05+02:00
Bug 41149: Re-enable DLL injection protection in all builds not just nightlies

- - - - -
c49cd408 by Matthew Finkel at 2023-05-08T11:01:05+02:00
Bug 24796: Comment out excess permissions from GeckoView

The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's
manifest, so we can't use the ifdef preprocessor guards around the
permissions we do not want. Commenting the permissions is the
next-best-thing.

- - - - -
c63107e2 by Matthew Finkel at 2023-05-08T11:01:06+02:00
Bug 25741: TBA: Disable GeckoNetworkManager

The browser should not need information related to the network
interface or network state, tor should take care of that.

- - - - -
b7863e91 by Matthew Finkel at 2023-05-08T11:01:09+02:00
Bug 28125: Prevent non-Necko network connections

- - - - -
d981aeb5 by Mike Perry at 2023-05-08T11:01:09+02:00
Bug 12974: Disable NTLM and Negotiate HTTP Auth

The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421,
https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602

- - - - -
8c1a75d3 by Alex Catarineu at 2023-05-08T11:01:10+02:00
Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899

- - - - -
e3357606 by Georg Koppen at 2023-05-08T11:01:10+02:00
Bug 16285: Exclude ClearKey system for now

In the past the ClearKey system had not been compiled when specifying
--disable-eme. But that changed and it is even bundled nowadays (see:
Mozilla's bug 1300654). We don't want to ship it right now as the use
case for it is not really visible while the code had security
vulnerabilities in the past.

- - - - -
24101a0d by Kathy Brade at 2023-05-08T11:01:13+02:00
Bug 21431: Clean-up system extensions shipped in Firefox

Only ship the pdfjs extension.

- - - - -
d51d23e6 by Kathy Brade at 2023-05-08T11:01:13+02:00
Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc.

Hide elements on about:logins that mention sync, "Firefox LockWise", and
Mozilla's LockWise mobile apps.

Disable the "Create New Login" button when security.nocertdb is true.

- - - - -
2945e91d by Alex Catarineu at 2023-05-08T11:01:14+02:00
Bug 41457: Remove Mozilla permissions

Bug 40025: Remove Mozilla add-on install permissions

- - - - -
cf23c4a7 by Kathy Brade at 2023-05-08T11:01:14+02:00
Bug 40002: Remove about:ion

Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people
volunteer to participate in studies that collect detailed, sensitive data about
how they use their browser.

- - - - -
111eead7 by Arthur Edelstein at 2023-05-08T11:01:14+02:00
Bug 26353: Prevent speculative connect that violated FPI.

Connections were observed in the catch-all circuit when
the user entered an https or http URL in the URL bar, or
typed a search term.

- - - - -
2cf47e72 by Alex Catarineu at 2023-05-08T11:01:15+02:00
Bug 31740: Remove some unnecessary RemoteSettings instances

More concretely, SearchService.jsm 'hijack-blocklists' and
url-classifier-skip-urls.

Avoid creating instance for 'anti-tracking-url-decoration'.

If prefs are disabling their usage, avoid creating instances for
'cert-revocations' and 'intermediates'.

Do not ship JSON dumps for collections we do not expect to need. For
the ones in the 'main' bucket, this prevents them from being synced
unnecessarily (the code in remote-settings does so for collections
in the main bucket for which a dump or local data exists). For the
collections in the other buckets, we just save some size by not
shipping their dumps.

We also clear the collections database on the v2 -> v3 migration.

- - - - -
fbfe0932 by Georg Koppen at 2023-05-08T11:01:15+02:00
Bug 30541: Disable WebGL readPixel() for web content

Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034

- - - - -
91cae3cd by Alex Catarineu at 2023-05-08T11:01:16+02:00
Bug 28369: Stop shipping pingsender executable

- - - - -
16012ce7 by Alex Catarineu at 2023-05-08T11:01:16+02:00
Bug 40073: Disable remote Public Suffix List fetching

In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented
fetching the Public Suffix List via RemoteSettings and replacing the default
one at runtime, which we do not want.

- - - - -
9fc9b474 by Mike Perry at 2023-05-08T11:01:16+02:00
Firefox preference overrides.

This hack directly includes our preference changes in omni.ja.

Bug 18292: Staged updates fail on Windows

Temporarily disable staged updates on Windows.

Bug 18297: Use separate Noto JP,KR,SC,TC fonts

Bug 23404: Add Noto Sans Buginese to the macOS whitelist

Bug 23745: Set dom.indexedDB.enabled = true

Bug 13575: Disable randomised Firefox HTTP cache decay user tests.
(Fernando Fernandez Mancera <ffmancera at riseup.net>)

Bug 17252: Enable session identifiers with FPI

Session tickets and session identifiers were isolated
by OriginAttributes, so we can re-enable them by
allowing the default value (true) of
"security.ssl.disable_session_identifiers".

The pref "security.enable_tls_session_tickets" is obsolete
(removed in https://bugzilla.mozilla.org/917049)

Bug 14952: Enable http/2 and AltSvc

In Firefox, SPDY/HTTP2 now uses Origin Attributes for
isolation of connections, push streams, origin frames, etc.
That means we get first-party isolation provided
"privacy.firstparty.isolate" is true. So in this patch, we
stop overriding "network.http.spdy.enabled" and
"network.http.spdy.enabled.http2".

Alternate Services also use Origin Attributes for isolation.
So we stop overriding
"network.http.altsvc.enabled" and "network.http.altsvc.oe"
as well.

(All 4 of the abovementioned "network.http.*" prefs adopt
Firefox 60ESR's default value of true.)

However, we want to disable HTTP/2 push for now, so we
set "network.http.spdy.allow-push" to false.

"network.http.spdy.enabled.http2draft" was removed in Bug 1132357.
"network.http.sped.enabled.v2" was removed in Bug 912550.
"network.http.sped.enabled.v3" was removed in Bug 1097944.
"network.http.sped.enabled.v3-1" was removed in Bug 1248197.

Bug 26114: addons.mozilla.org is not special
* Don't expose navigator.mozAddonManager on any site
* Don't block NoScript from modifying addons.mozilla.org or other sites

Enable ReaderView mode again (#27281).

Bug 29916: Make sure enterprise policies are disabled

Bug 2874: Block Components.interfaces from content

Bug 26146: Spoof HTTP User-Agent header for desktop platforms

In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent
header and to JavaScript code via navigator.userAgent. To avoid
leaking the OS inside each HTTP request (which many web servers
log), always use the Windows 7 OS value in the desktop User-Agent
header. We continue to allow access to the actual OS via JavaScript,
since doing so improves compatibility with web applications such
as GitHub and Google Docs.

Bug 12885: Windows Jump Lists fail for Tor Browser

Jumplist entries are stored in a binary file in:
  %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\
and has a name in the form
  [a-f0-9]+.customDestinations-ms

The hex at the front is unique per app, and is ultimately derived from
something called the 'App User Model ID' (AUMID) via some unknown
hashing method. The AUMID is provided as a key when programmatically
creating, updating, and deleting a jumplist. The default behaviour in
firefox is for the installer to define an AUMID for an app, and save it
in the registry so that the jumplist data can be removed by the
uninstaller.

However, the Tor Browser does not set this (or any other) regkey during
installation, so this codepath fails and the app's AUMID is left
undefined. As a result the app's AUMID ends up being defined by
windows, but unknowable by Tor Browser. This unknown AUMID is used to
create and modify the jumplist, but the delete API requires that we
provide the app's AUMID explicitly. Since we don't know what the AUMID
is (since the expected regkey where it is normally stored does not
exist) jumplist deletion will fail and we will leave behind a mostly
empty customDestinations-ms file. The name of the file is derived from
the binary path, so an enterprising person could reverse engineer how
that hex name is calculated, and generate the name for Tor Browser's
default Desktop installation path to determine whether a person had
used Tor Browser in the past.

The 'taskbar.grouping.useprofile' option that is enabled by this patch
works around this AUMID problem by having firefox.exe create it's own
AUMID based on the profile path (rather than looking for a regkey). This
way, if a user goes in and enables and disables jumplist entries, the
backing store is properly deleted.

Unfortunately, all windows users currently have this file lurking in
the above mentioned directory and this patch will not remove it since it
was created with an unknown AUMID. However, another patch could be
written which goes to that directory and deletes any item containing the
'Tor Browser' string.  See bug 28996.

Bug 30845: Make sure default themes and other internal extensions are enabled

Bug 28896: Enable extensions in private browsing by default

Bug 31065: Explicitly allow proxying localhost

Bug 31598: Enable letterboxing

Disable Presentation API everywhere

Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer
security levels.

Bug 32321: Disable Mozilla's MitM pings

Bug 19890: Disable installation of system addons

By setting the URL to "" we make sure that already installed system
addons get deleted as well.

Bug 22548: Firefox downgrades VP9 videos to VP8.

On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor
Browser 7.0 all youtube videos are degraded to VP8.

This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0.
All clients will get better experience and lower traffic, beause TBB doesn't
use "Use hardware acceleration when available".

Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs

Bug 16441: Suppress "Reset Tor Browser" prompt.

Bug 29120: Use the in-memory media cache and increase its maximum size.

Bug 33697: use old search config based on list.json

Bug 33855: Ensure that site-specific browser mode is disabled.

Bug 30682: Disable Intermediate CA Preloading.

Bug 40061: Omit the Windows default browser agent from the build

Bug 40322: Consider disabling network.connectivity-service.enabled

Bug 40408: Disallow SVG Context Paint in all web content

Bug 40308: Disable network partitioning until we evaluate dFPI

Bug 40322: Consider disabling network.connectivity-service.enabled

Bug 40383: Disable dom.enable_event_timing

Bug 40423: Disable http/3

Bug 40177: Update prefs for Fx91esr

Bug 40700: Disable addons and features recommendations

Bug 40682: Disable network.proxy.allow_bypass

Bug 40736: Disable third-party cookies in PBM

Bug 19850: Enabled HTTPS-Only by default

Bug 40912: Hide the screenshot menu

Bug 41292: Disable moreFromMozilla in preferences page

Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector

Bug 24686: Set network.http.tailing.enabled to true

Bug 40183: Disable TLS ciphersuites using SHA-1

Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102

We reviewed all the preferences we set for 102, and remove a few old
ones. See the description of that issue to see all the preferences we
believed were still valid for 102, and some brief description for the
reasons to keep them.

- - - - -
7c2109ae by Pier Angelo Vendrame at 2023-05-08T11:01:17+02:00
fixup! Firefox preference overrides.

Bug 41683: Disable the network process on Windows

- - - - -
990a4f63 by Richard Pospesel at 2023-05-08T11:01:17+02:00
Bug 41659: Add canonical color definitions to base-browser

- - - - -
4992028b by Pier Angelo Vendrame at 2023-05-08T11:01:18+02:00
Bug 41043: Hardcode the UI font on Linux

The mechanism to choose the UI font does not play well with our
fontconfig configuration. As a result, the final criterion to choose
the font for the UI was its version.

Since we hardcode Arimo as a default sans-serif on preferences, we use
it also for the UI. FontConfig will fall back to some other font for
scripts Arimo does not cover as expected (we tested with Japanese).

- - - - -
7635c171 by Alex Catarineu at 2023-05-08T11:01:18+02:00
Bug 30605: Honor privacy.spoof_english in Android

This checks `privacy.spoof_english` whenever `setLocales` is
called from Fenix side and sets `intl.accept_languages`
accordingly.

Bug 40198: Expose privacy.spoof_english pref in GeckoView

- - - - -
c4a6b22f by Alex Catarineu at 2023-05-08T11:01:19+02:00
Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView

- - - - -
2c84b001 by Alex Catarineu at 2023-05-08T11:01:19+02:00
Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware

- - - - -
0e8619e7 by Alex Catarineu at 2023-05-08T11:01:19+02:00
Bug 26345: Hide tracking protection UI

- - - - -
6f537087 by Kathy Brade at 2023-05-08T11:01:20+02:00
Bug 9173: Change the default Firefox profile directory to be relative.

This should eliminate our need to rely on a wrapper script that
sets /Users/arthur and launches Firefox with -profile.

- - - - -
2e99fd39 by Alex Catarineu at 2023-05-08T11:01:20+02:00
Bug 27604: Fix addon issues when moving the profile directory

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838

- - - - -
cdab4157 by Mike Perry at 2023-05-08T11:01:21+02:00
Bug 13028: Prevent potential proxy bypass cases.

It looks like these cases should only be invoked in the NSS command line
tools, and not the browser, but I decided to patch them anyway because there
literally is a maze of network function pointers being passed around, and it's
very hard to tell if some random code might not pass in the proper proxied
versions of the networking code here by accident.

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509

- - - - -
eb7e8a30 by Kathy Brade at 2023-05-08T11:01:21+02:00
Bug 11641: Disable remoting by default.

Unless the -osint command line flag is used, the browser now defaults
to the equivalent of -no-remote.  There is a new -allow-remote flag that
may be used to restore the original (Firefox-like) default behavior.

- - - - -
7bdd1660 by Igor Oliveira at 2023-05-08T11:01:22+02:00
Bug 23104: Add a default line height compensation

Many fonts have issues with their vertical metrics. they
are used to influence the height of ascenders and depth
of descenders. Gecko uses it to calculate the line height
(font height + ascender + descender), however because of
that idiosyncratic behavior across multiple operating
systems, it can be used to identify the user's OS.

The solution proposed in the patch uses a default factor
to be multiplied with the font size, simulating the concept
of ascender and descender. This way all operating
systems will have the same line height only and only if the
frame is outside the chrome.

- - - - -
e2fa4062 by Pier Angelo Vendrame at 2023-05-08T11:01:22+02:00
Bug 40309: Avoid using regional OS locales

Avoid regional OS locales if the pref
`intl.regional_prefs.use_os_locales` is false but RFP is enabled.

- - - - -
59df37bb by Matthew Finkel at 2023-05-08T11:01:22+02:00
Bug 40432: Prevent probing installed applications

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084

- - - - -
2d0ca8f6 by hackademix at 2023-05-08T11:01:23+02:00
Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs.

- - - - -
90b41dac by hackademix at 2023-05-08T11:01:23+02:00
Bug 41434: Letterboxing, improve logging.

- - - - -
331323ba by hackademix at 2023-05-08T11:01:24+02:00
Bug 31064: Letterboxing, exempt browser extensions.

- - - - -
53f91b11 by hackademix at 2023-05-08T11:01:24+02:00
Bug 32411: Letterboxing, exempt view-source: URIs.

- - - - -
971019f7 by Richard Pospesel at 2023-05-08T11:01:24+02:00
Bug 32220: Improve the letterboxing experience

CSS and JS changes to alter the UX surrounding letterboxing. The
browser element containing page content is now anchored to the bottom
of the toolbar, and the remaining letterbox margin is the same color
as the firefox chrome. The letterbox margin and outline are tied to
the currently selected theme.

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1594455

- - - - -
f3715bef by Alex Catarineu at 2023-05-08T11:01:25+02:00
Bug 40069: Add helpers for message passing with extensions

- - - - -
b06f6c6a by Matthew Finkel at 2023-05-08T11:01:25+02:00
Bug 40253: Explicitly allow NoScript in Private Browsing mode.

- - - - -
c5c39b6c by Pier Angelo Vendrame at 2023-05-08T11:01:26+02:00
Bug 41369: Improve Firefox language settings for multi-lingual packages

Change the language selector to be sorted by language code, rather than
name, and to display the language code to the user.

Bug 41372: Handle Japanese as a special case in preferences on macOS

Japanese is treated in a special way on macOS. However, seeing the
Japanese language tag could be confusing for users, and moreover the
language name is not localized correctly like other langs.

Bug 41378: Tell users that they can change their language at the first start

With multi-lingual builds, Tor Browser matches the user's system
language, but some users might want to change it.
So, we tell them that it is possible, but only once.

- - - - -
138de20c by Henry Wilkes at 2023-05-08T11:01:26+02:00
Bug 41371: Temporary hack to fix language selector popup position

- - - - -
bd218069 by Pier Angelo Vendrame at 2023-05-08T11:01:27+02:00
Bug 41417: Always prompt users to restart after changing language

This is a temporary patch that we need until we switch our strings to
Fluent. The reason is that we currently set strings when we populate
our XUL content.
We could rework the whole mechanism, but it is not worth it because we
want to switch to Fluent, which will handle everything automatically.

- - - - -
86648500 by Pier Angelo Vendrame at 2023-05-08T11:01:27+02:00
Bug 40925: Implemented the Security Level component

This component adds a new Security Level toolbar button which visually
indicates the current global security level via icon (as defined by the
extensions.torbutton.security_slider pref), a drop-down hanger with a
short description of the current security level, and a new section in
the about:preferences#privacy page where users can change their current
security level. In addition, the hanger and the preferences page will
show a visual warning when the user has modified prefs associated with
the security level and provide a one-click 'Restore Defaults' button to
get the user back on recommended settings.

Bug 40125: Expose Security Level pref in GeckoView

- - - - -
240fb51b by Pier Angelo Vendrame at 2023-05-08T11:01:27+02:00
Bug 40926: Implemented the New Identity feature

- - - - -
e56bdf6c by cypherpunks1 at 2023-05-08T11:01:28+02:00
Bug 40717: Hide Windows SSO in settings

(cherry picked from commit 1bacd26df8a8ffe481e11ec6b8323150fdf2011d)
- - - - -
136abaec by cypherpunks1 at 2023-05-08T11:01:28+02:00
Bug 41565: Gate Telemetry Tasks behind MOZ_TELEMETRY_REPORTING

(cherry picked from commit 47eb7d305746bd1a9e328b1fb7fef40d56769d5b)
- - - - -
7c2cfde6 by Pier Angelo Vendrame at 2023-05-08T11:01:31+02:00
Bug 41603: Customize the creation of MOZ_SOURCE_URL

MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and
MOZ_SOURCE_CHANGESET.
But the code takes for granted that it refers to a Hg instance, so it
combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`.
With this commit, we change this logic to combine them to create a URL
that is valid for GitLab.
$MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag.
If that is needed, we could use /-/tree/, instead of /-/commit/.

- - - - -
e20003a6 by Pier Angelo Vendrame at 2023-05-08T11:01:31+02:00
Bug 41542: Disable the creation of a default profile

Firefox creates a profile as a fallback for old versions.
However, we do not need this, so we want to prevent Firefox from
creating the related directories.

We comment out the code, but should Mozilla be interested in a
compile-time flag, we could rewrite the patch to add one.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1770174.

- - - - -
042af9e8 by Arthur Edelstein at 2023-05-08T11:01:32+02:00
Bug 18905: Hide unwanted items from help menu

Bug 25660: Remove the "New Private Window" option

(cherry picked from commit 5ff98c20700d45b9bc57d970ff45c1e6519cd64d)
- - - - -

30 changed files:

- .eslintignore
- + .gitlab/issue_templates/UXBug.md
- + .gitlab/issue_templates/bug.md
- browser/app/macbuild/Contents/MacOS-files.in
- browser/app/permissions
- + browser/app/profile/001-base-profile.js
- browser/app/profile/firefox.js
- browser/base/content/appmenu-viewcache.inc.xhtml
- browser/base/content/browser-menubar.inc
- browser/base/content/browser-safebrowsing.js
- browser/base/content/browser-sets.inc
- browser/base/content/browser-siteIdentity.js
- browser/base/content/browser.css
- browser/base/content/browser.js
- browser/base/content/browser.xhtml
- + browser/base/content/languageNotification.js
- browser/base/content/main-popupset.inc.xhtml
- browser/base/content/navigator-toolbox.inc.xhtml
- browser/base/jar.mn
- + browser/branding/alpha/document_pdf.ico
- browser/components/BrowserGlue.jsm
- browser/components/about/AboutRedirector.cpp
- browser/components/about/components.conf
- browser/components/aboutlogins/AboutLoginsParent.jsm
- browser/components/aboutlogins/content/aboutLogins.css
- browser/components/aboutlogins/content/aboutLogins.js
- browser/components/aboutlogins/content/components/fxaccounts-button.css
- browser/components/moz.build
- + browser/components/newidentity/content/newidentity.js
- + browser/components/newidentity/jar.mn

The diff was not included because it is too large.

View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/2686fa64a28c988b2fc8f11e9087908fb85ad6e1...042af9e8c1c0f5b5c47ff734690f193b2b1485f4

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/2686fa64a28c988b2fc8f11e9087908fb85ad6e1...042af9e8c1c0f5b5c47ff734690f193b2b1485f4
You're receiving this email because of your account on gitlab.torproject.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tbb-commits/attachments/20230509/c09d21d0/attachment-0001.htm>