[tbb-commits] [Git][tpo/applications/android-components][android-components-102.0.14-12.0-1] Close #12926: Use external flag when opening fallback URL

[Richard Pospesel (@richard)]

Richard Pospesel pushed to branch android-components-102.0.14-12.0-1 at The Tor Project / Applications / android-components


Commits:
67e3c6ae by Roger Yang at 2022-11-17T19:40:29+00:00
Close #12926: Use external flag when opening fallback URL

- - - - -


2 changed files:

- components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngineSession.kt
- components/browser/engine-gecko/src/test/java/mozilla/components/browser/engine/gecko/GeckoEngineSessionTest.kt


Changes:

=====================================
components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngineSession.kt
=====================================
@@ -588,7 +588,7 @@ class GeckoEngineSession(
                 )?.apply {
                     when (this) {
                         is InterceptionResponse.Content -> loadData(data, mimeType, encoding)
-                        is InterceptionResponse.Url -> loadUrl(url)
+                        is InterceptionResponse.Url -> loadUrl(url, flags = LoadUrlFlags.external())
                         is InterceptionResponse.AppIntent -> {
                             notifyObservers {
                                 onLaunchIntentRequest(url = url, appIntent = appIntent)


=====================================
components/browser/engine-gecko/src/test/java/mozilla/components/browser/engine/gecko/GeckoEngineSessionTest.kt
=====================================
@@ -1664,7 +1664,7 @@ class GeckoEngineSessionTest {
 
         assertEquals("sample:about", interceptorCalledWithUri)
         verify(geckoSession).load(
-            GeckoSession.Loader().uri("https://mozilla.org")
+            GeckoSession.Loader().uri("https://mozilla.org").flags(LoadUrlFlags.EXTERNAL),
         )
     }
 



View it on GitLab: https://gitlab.torproject.org/tpo/applications/android-components/-/commit/67e3c6aef632d3849f782c18c0f2af11919cb212

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/android-components/-/commit/67e3c6aef632d3849f782c18c0f2af11919cb212
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tbb-commits/attachments/20221117/f5d8f7ed/attachment-0001.htm>