[tbb-commits] [Git][tpo/applications/tor-browser][tor-browser-102.5.0esr-12.5-1] fixup! Bug 23247: Communicating security expectations for .onion

[Pier Angelo Vendrame (@pierov)]

Pier Angelo Vendrame pushed to branch tor-browser-102.5.0esr-12.5-1 at The Tor Project / Applications / Tor Browser


Commits:
9b2acde7 by cypherpunks1 at 2022-12-17T22:06:06+00:00
fixup! Bug 23247: Communicating security expectations for .onion

Bug 40347: Fix the "not secure" icon and text on view-source:http://*.onion addresses

- - - - -


1 changed file:

- browser/base/content/browser-siteIdentity.js


Changes:

=====================================
browser/base/content/browser-siteIdentity.js
=====================================
@@ -857,11 +857,11 @@ var gIdentityHandler = {
     } else if (this._isAboutNetErrorPage || this._isAboutBlockedPage) {
       // Network errors and blocked pages get a more neutral icon
       this._identityBox.className = "unknownIdentity";
+    } else if (this._uriIsOnionHost) {
+      this._identityBox.className = "onionUnknownIdentity";
     } else if (this._isPotentiallyTrustworthy) {
-      // This is a local resource or an onion site (and shouldn't be marked insecure).
-      this._identityBox.className = this._uriIsOnionHost
-        ? "onionUnknownIdentity"
-        : "localResource";
+      // This is a local resource (and shouldn't be marked insecure).
+      this._identityBox.className = "localResource";
     } else {
       // This is an insecure connection.
       let warnOnInsecure =



View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/9b2acde7486e345489469100919b06d7093ff29d

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/9b2acde7486e345489469100919b06d7093ff29d
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tbb-commits/attachments/20221219/926ff533/attachment-0001.htm>