[tbb-commits] [tor-browser] 29/179: Bug 1773223 - Use the GN binary path passed into generate_gn_config. r=firefox-build-system-reviewers, andi a=RyanVM

gitolite role git at cupani.torproject.org
Fri Aug 19 08:35:26 UTC 2022


This is an automated email from the git hooks/post-receive script.

pierov pushed a commit to branch tor-browser-102.2.0esr-12.0-1
in repository tor-browser.

commit fbeb69f52e6d961cbd38bc61d431262ffb3e68ca
Author: Mike Hommey <mh+mozilla at glandium.org>
AuthorDate: Mon Jun 20 21:50:58 2022 +0000

    Bug 1773223 - Use the GN binary path passed into generate_gn_config. r=firefox-build-system-reviewers,andi a=RyanVM
    
    The path is given to the function, there is no need to get it from
    config.substs.
    
    Differential Revision: https://phabricator.services.mozilla.com/D149207
---
 python/mozbuild/mozbuild/gn_processor.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/python/mozbuild/mozbuild/gn_processor.py b/python/mozbuild/mozbuild/gn_processor.py
index 1598c53b9f756..6172a8e272c3c 100644
--- a/python/mozbuild/mozbuild/gn_processor.py
+++ b/python/mozbuild/mozbuild/gn_processor.py
@@ -623,7 +623,7 @@ def generate_gn_config(
         ]
     )
     out_dir = mozpath.join(output, "gn-output")
-    gen_args = [config.substs["GN"], "gen", out_dir, gn_args, "--ide=json"]
+    gen_args = [gn_binary, "gen", out_dir, gn_args, "--ide=json"]
     print('Running "%s"' % " ".join(gen_args), file=sys.stderr)
     subprocess.check_call(gen_args, cwd=srcdir, stderr=subprocess.STDOUT)
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the tbb-commits mailing list