[tbb-commits] [tor-browser/tor-browser-68.1.0esr-9.0-2] Bug 1578075 - Increase stack size of paint threads on macOS Catalina to 2MB. r=jrmuizel

gk at torproject.org gk at torproject.org
Fri Sep 27 05:41:59 UTC 2019


commit 7813cebd9f79de65d16e262ce79b675e7ec132c3
Author: Lee Salzman <lsalzman at mozilla.com>
Date:   Thu Sep 26 02:31:15 2019 +0000

    Bug 1578075 - Increase stack size of paint threads on macOS Catalina to 2MB. r=jrmuizel
    
    Still getting some crash reports on nightly with a 1MB stack. Let's try one more time
    with 2MB just to see if we can eliminate those. If this fails, then we may need to consider
    more drastic approaches like disabling OMTP in this case.
    
    Differential Revision: https://phabricator.services.mozilla.com/D47080
    
    --HG--
    extra : moz-landing-system : lando
---
 gfx/layers/PaintThread.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gfx/layers/PaintThread.cpp b/gfx/layers/PaintThread.cpp
index 400e2d342b2f..40ba4d3954b1 100644
--- a/gfx/layers/PaintThread.cpp
+++ b/gfx/layers/PaintThread.cpp
@@ -79,7 +79,7 @@ static uint32_t GetPaintThreadStackSize() {
 #else
   // Workaround bug 1578075 by increasing the stack size of paint threads
   if (nsCocoaFeatures::OnCatalinaOrLater()) {
-    static const uint32_t kCatalinaPaintThreadStackSize = 1024 * 1024;
+    static const uint32_t kCatalinaPaintThreadStackSize = 2 * 1024 * 1024;
     static_assert(kCatalinaPaintThreadStackSize >= nsIThreadManager::DEFAULT_STACK_SIZE,
                   "update default stack size of paint "
                   "workers");



More information about the tbb-commits mailing list