[tbb-commits] [torbutton/maint-1.9.7] Bug 23949: Fix bug in donation banner that prevented display

[gk at torproject.org]

commit f58bab3851c28fbb8145552349bfdaf62ee1054e
Author: Arthur Edelstein <arthuredelstein at gmail.com>
Date:   Sun Oct 22 18:19:33 2017 -0700

    Bug 23949: Fix bug in donation banner that prevented display
---
 src/modules/donation-banner.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/modules/donation-banner.js b/src/modules/donation-banner.js
index 3a954e5..ac397e5 100644
--- a/src/modules/donation-banner.js
+++ b/src/modules/donation-banner.js
@@ -52,7 +52,8 @@ const gStringBundle = Services.strings.createBundle(kPropertiesURL);
 const shouldShowBanner = function (shortLocale) {
   try {
     // If our override test pref is true, then just show the banner regardless.
-    if (Services.prefs.getBoolPref("extensions.torbutton.testBanner", false)) {
+    if (Services.prefs.prefHasUserValue("extensions.torbutton.testBanner") &&
+        Services.prefs.getBoolPref("extensions.torbutton.testBanner") === true) {
       return true;
     }
     // Don't show a banner if update is needed.