[tbb-bugs] #19757 [Applications/Tor Browser]: Make a menu to add onion and auth-cookie to TB

[Tor Bug Tracker & Wiki]

#19757: Make a menu to add onion and auth-cookie to TB
-------------------------------------------------+-------------------------
 Reporter:  mrphs                                |          Owner:  brade
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ux-team, tbb-usability, tor-hs,      |  Actual Points:  6.3
  TorBrowserTeam202001                           |
Parent ID:  #30000                               |         Points:  8
 Reviewer:  pospeselr, acat                      |        Sponsor:
                                                 |  Sponsor27-must
-------------------------------------------------+-------------------------
Changes (by acat):

 * status:  needs_review => needs_revision
 * keywords:  ux-team, tbb-usability, tor-hs, TorBrowserTeam202001R => ux-
     team, tbb-usability, tor-hs, TorBrowserTeam202001


Comment:

 In `savedKeysDialog.js`, line 64, `controllerFailureMsg` is not defined in
 that scope. I guess it should be declared outside the `try`, as you do in
 `authPrompt.js` [eslint caught this one :) ]

 Speaking of eslint, I'm not sure whether we made a decision about
 enforcing it for new code or not but at least with the latest patches of
 pospeselr or mine we tried to do so. I leave it up to you, as I think it's
 not so important and can always be done later. `./mach lint -l eslint
 --fix browser/components/onionservices` should fix all the auto-fixable
 issues.

 I tested a bit and saw a couple of cases with a behaviour I'm not sure is
 the intended one:

 * Added private key, checked "Don't remember" -> after "New Identity"
 accessing to the .onion still works (I would expect we clear that on New
 Identity).

 * Added private key, checked "Remember", removed from `about:preferences`
 -> accessing to the .onion still works (but not after "New Identity",
 which is surprising given the behaviour above).

 Should we fix these or is this working as intended?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19757#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online