[tbb-bugs] #32435 [Applications/Tor Browser]: Compile clang for Linux x86_64 with WASM support
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Jan 21 08:09:45 UTC 2020
#32435: Compile clang for Linux x86_64 with WASM support
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: task | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-security, GeorgKoppen202001, | Actual Points:
TorBrowserTeam202001R |
Parent ID: #32434 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):
* keywords: tbb-security, GeorgKoppen202001, TorBrowserTeam202001 => tbb-
security, GeorgKoppen202001, TorBrowserTeam202001R
* status: needs_revision => needs_review
Comment:
Replying to [comment:5 boklm]:
> Replying to [comment:4 gk]:
> > `bug_32389` (https://gitweb.torproject.org/user/gk/tor-browser-
build.git/commit/?h=bug_32389&id=298b18f9e1319077e8909b5ec43f270fbfabf405)
has a build patch up for review.
>
> One small simplification: I think the line `rlbox: '[% c("var/nightly")
&& c("var/linux-x86_64") %]'` can be moved to `targets/linux-x86_64`
instead of `targets/linux`, so that the part `&& c("var/linux-x86_64")`
can be removed.
> We can also remove the lines `rlbox: 0` for the other platforms, as it
is disabled by default.
Done on `bug_32389_v2` (https://gitweb.torproject.org/user/gk/tor-browser-
build.git/commit/?h=bug_32389_v2&id=a1eab9035af5b5d6cc8ab21615676f9f237c074f).
I thought it would make it easier to clarify that the feature actually is
disabled on other platforms/architectures, in particular as we e.g. set
the snowflake part for Android to `0` explicitly, but fine with me. Should
I file a ticket to correct that (and the `namecoin: 0` ones)?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32435#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list