[tbb-bugs] #28704 [Applications/Tor Browser]: Compile Tor and dependencies on our own for Android

[Tor Bug Tracker & Wiki]

#28704: Compile Tor and dependencies on our own for Android
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  sisbell
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity,     |  Actual Points:
  TorBrowserTeam202001                           |
Parent ID:                                       |         Points:  0
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by boklm):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202001R => tbb-
     mobile, tbb-rbm, tbb-parity, TorBrowserTeam202001
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:13 sisbell]:
 > I have 4 commit covering child tickets:
 >
 >     Bug 32993: Package Tor With Tor Android Service Project[[BR]]    Bug
 28766: Tor Build for Android[[BR]]    Bug 28765: !LibEvent Build for
 Android[[BR]]    Bug 28764: OpenSSL Build for
 Android[[BR]]https://github.com/sisbell/tor-browser-build/commits/bug-
 28766c
 >
 > I verified that tor starts up correctly with the armv7 build on a
 device. The browser loads and displays pages. I have not verified
 reproducibility yet.

 Some comments/questions:
 - in the builds of openssl, libevent, tor, you are setting
 `ANDROID_NDK_HOME` and adding `$ANDROID_NDK_HOME` to `PATH`. Shouldn't
 that be done in `var/setup` in `projects/android-toolchain/config` instead
 of in each project?
 - could you explain (for example in the commit message) why libevent needs
 to be updated from 2.1.8 to 2.1.11?
 - could you explain why the `--disable-libevent-regress` `--disable-
 samples` options are needed to build libevent (and whether it would be
 useful to use them on other platforms too)?
 - in the libevent build, you are adding CC=clang to the configure for all
 platforms. I think it should be added to the android builds only as it
 doesn't seem to be needed for other platforms.
 - it seems we could have a `var/configure_opt` for android in `rbm.conf`
 containing something like `CC=clang --host=[% c("var/host") %] [%
 c("var/configure_opt_project") %]`, where `var/configure_opt_project` is
 defined in each project to define options specific to this project
 - I think the name `var/host` is a little confusing and could be renamed
 to `var/configure_host` to make it more clear where it's used

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28704#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online