[tbb-bugs] #31984 [Applications/Tor Browser]: TB 9.x partial update: unable to remove directory: tobedeleted

[Tor Bug Tracker & Wiki]

#31984: TB 9.x partial update: unable to remove directory: tobedeleted
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  brade
     Type:  defect                               |         Status:  closed
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  not a
 Keywords:  tbb-9.0, tbb-update,                 |  bug
  TorBrowserTeam202002                           |  Actual Points:
Parent ID:                                       |         Points:  1.0
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mcs):

 * status:  assigned => closed
 * resolution:   => not a bug


Comment:

 Unless the original blog commenter experienced a failed incremental
 update, this is not a bug. My guess is that they saw a line in their
 update log file that appeared to be an error and wanted to let us know
 about it.

 Kathy and I confirmed that the log message occurs in the normal course of
 things. What happens is that, on Windows, `updater.exe` cannot delete the
 DLLs that it depends on. The files are renamed and moved to a temporary
 directory named `tobedeleted`. In Firefox, `MoveFileEx()` is used to tell
 the OS remove that directory upon next reboot. Since that mechanism will
 write to the Windows Registry (which we want to avoid), our Tor Browser
 patches for #4234 add an `#ifdef` to omit the block of code that uses
 `MoveFileEx()`, here:
 https://gitweb.torproject.org/tor-
 browser.git/tree/toolkit/mozapps/update/updater/updater.cpp?h=tor-
 browser-68.3.0esr-9.5-1-build1#n4007

 To make sure `tobedeleted` and its contents are eventually removed in Tor
 Browser, we added code to do so during browser start up, here:
 https://gitweb.torproject.org/tor-
 browser.git/tree/toolkit/xre/nsUpdateDriver.cpp?h=tor-
 browser-68.3.0esr-9.5-1-build1#n879

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31984#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online