[tbb-bugs] #19251 [Applications/Tor Browser]: TorBrowser might want to have an error page specific to when .onion links fail

[Tor Bug Tracker & Wiki]

#19251: TorBrowser might want to have an error page specific to when .onion links
fail
--------------------------------------------+------------------------------
 Reporter:  cypherpunks                     |          Owner:  brade
     Type:  enhancement                     |         Status:  needs_review
 Priority:  Low                             |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ux-team, TorBrowserTeam202002R  |  Actual Points:  4.5
Parent ID:  #30025                          |         Points:  6
 Reviewer:  acat,pospeselr                  |        Sponsor:
                                            |  Sponsor27-must
--------------------------------------------+------------------------------
Changes (by mcs):

 * keywords:  ux-team, TorBrowserTeam202002 => ux-team,
               TorBrowserTeam202002R
 * status:  assigned => needs_review
 * reviewer:   => acat,pospeselr


Comment:

 While we are waiting for strings (#33035), Kathy and I think it would be
 OK to do a first round of reviews of the implementation.

 For Torbutton we added strings for the error pages (currently, most of
 them are placeholders and therefore they are not ready for translation).

 For the browser, we did the following:
 * Added an OnionServicesAboutNetError module which enhances Firefox's
 built-in about:netError page to add descriptive text that is tailored to
 each onion service error as well as a visual diagram to help people
 understand where the error occurred.
 * Added support for two additional SOCKS extended errors:
 `SOCKS5_HS_BAD_ADDRESS` (typo in .onion address) and
 `SOCKS5_HS_INTRO_TIMEDOUT` (introduction timed out).
 * Made changes to the onion service authentication prompt logic so the
 browser displays an appropriate error page after the prompt is canceled.

 https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug19251-01&id=0979f4acf33539cd12d8bcf89f8e18d69bc5ce99

 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug19251-01&id=eb4443ba40b28d6984e7142773004823a5460b68

 I added Alex and Richard as reviewers.
 Matt: please change that if you have a different idea.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19251#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online