[tbb-bugs] #33892 [Applications/Tor Browser]: Add brandProductName to torbutton brand localization files

[Tor Bug Tracker & Wiki]

#33892: Add brandProductName to torbutton brand localization files
--------------------------------------+------------------------------
 Reporter:  acat                      |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam202004R     |  Actual Points:  0.75
Parent ID:  #33533                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------
Changes (by acat):

 * keywords:  TorBrowserTeam202004 => TorBrowserTeam202004R
 * status:  needs_information => needs_review
 * actualpoints:   => 0.75


Comment:

 Thanks, nice catch. I took the string from the already existing `-brand-
 product-name` in `tor-browser-brand.ftl`, but I didn't realize that it's
 not localized in Transifex, so the strings there are a bit outdated.

 I revised the patch to use `brandShortName` from .properties and .dtd,
 instead. Not sure what to do with the inconsistency that you mentioned for
 zh-CN. The script I used to revise the patch just took it from the
 respective .properties or .dtd file, so `brandProductName` is also
 translated in .properties but not in .dtd.

 I was thinking that perhaps it would be worth to take one brand file as
 the source (say brand.properties), and autogenerate the other two
 (brand.dtd and tor-browser-brand.ftl) when importing translations. At
 least for `tor-browser-brand.ftl` I think we should do it, since Fluent is
 not supported in Transifex, so this would be one way to keep it up to date
 when importing new translations.

 So in my `33533+2` branch I added a couple of commits:

 https://github.com/acatarineu/torbutton/commit/9e2c819e15c93362b27e0cb1d33d27dba9dfbaad
 is the revised one for this patch.

 https://github.com/acatarineu/torbutton/commit/04f8130c112facef3e204f568b2077ca1b045c07
 is some extra patch I did for autogenerating `tor-browser-brand.ftl`. I
 also ran the autogenerate part of `import-translations.sh` (without
 fetching for new translations), so there are actually some changes to
 `tor-browser-brand.ftl`. We can also do this in a separate ticket, or just
 drop it if you think there's a better approach for this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33892#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online