[tbb-bugs] #33890 [Applications/Tor Browser]: Rename .xul to .xhtml
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Apr 14 18:38:56 UTC 2020
#33890: Rename .xul to .xhtml
--------------------------------------+--------------------------------
Reporter: acat | Owner: tbb-team
Type: defect | Status: needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam202004 | Actual Points:
Parent ID: #33533 | Points:
Reviewer: | Sponsor:
--------------------------------------+--------------------------------
Changes (by mcs):
* status: needs_review => needs_revision
* keywords: TorBrowserTeam202004R => TorBrowserTeam202004
Comment:
Replying to [comment:1 acat]:
> torbutton patch:
https://github.com/acatarineu/torbutton/commit/782cc4b27d580c43d3db78690f9ab0803eb854af
Looks good. Just a couple of things:
* Please edit the comment in tor-circuit-display.js that refers to
"torbutton.xul" to instead point to browser/base/content/browser.xhtml.
* Is there a ticket that covers general cleanup of torbutton.css and
related files? For example, does #tor-button still exist anywhere? Maybe
this is covered by #28745?
> tor-launcher patch: https://github.com/acatarineu/tor-
launcher/commit/0bd09322f4af1b36e9ee60411a9fae608132d92a
In src/install.rdf, please also remove the commented out block with
<em:optionsURL>. It has never been used and keeping it causes grep to find
a reference to xul.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33890#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list