[tbb-bugs] #30832 [Applications/Tor Browser]: Fix tor-browser tbb-tests
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Apr 3 20:59:47 UTC 2020
#30832: Fix tor-browser tbb-tests
--------------------------------------+---------------------------
Reporter: acat | Owner: tbb-team
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ReleaseTrainMigration | Actual Points: 2
Parent ID: | Points:
Reviewer: | Sponsor: Sponsor58
--------------------------------------+---------------------------
Changes (by acat):
* actualpoints: => 2
Comment:
This took longer than expected.
Here is a branch with 6 fixups for tests: https://github.com/acatarineu
/tor-browser/commits/30832.
* f5202200d1ecdc56f0437f83210cb292ae40559e: the old <script> tags were not
working, and I had to set a targetOrigin of one `postMessage` to `*`,
otherwise it would complain about target being a different origin.
* c817518a544e1fada4a55f9ad3a064ed433ba90c: these are already tested in
tbb-testsuite, so leaving just a few just to check that our prefs file is
applied. Also removed a couple of files in `tbb-tests/browser.ini` which
still do not exist at this point.
* 581241ecfd605045561a73b648d1f3e017008c01: update to new async API and
add test to browser.ini.
* f452d6bbc04fc891b05a99173edaf408674b0012: update APIs and add test to
browser.ini.
* c73bfe7f3b21421c7349267f2abac9f90f503b73: we need `layout.css.line-
height.normal-as-resolved-value.enabled = false`, otherwise `line-height`
property is read as `normal` and we cannot get the number in pixels. Also
found that I needed to apply a `Math.round` to the read `fontSize`,
otherwise the calculated values would not match.
* 2e845b4c67ab78ca5096fd67fb9c031af9a34aac: ignoring onboarding tests,
changed logic for getting the starting commit in `run-tbb-tests` and added
a few necessary prefs.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30832#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list