[tbb-bugs] #31286 [Applications/Tor Browser]: Include bridge configuration into about:preferences

[Tor Bug Tracker & Wiki]

#31286: Include bridge configuration into about:preferences
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  pospeselr
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-9.0-must-alpha,                  |  Actual Points:
  TorBrowserTeam201909R, ff68-esr                |
Parent ID:  #10760                               |         Points:  15
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor44-can
-------------------------------------------------+-------------------------

Comment (by cypherpunks):

 What if you make Tor pane optional as `register_module("paneSync",
 gSyncPane);`?
 {{{
 +    // TODO: shouldn't this early out once meek settings are found?
 }}}
 Probably, no. Current implementation follows the GCC option override
 logic.
 {{{
 // weird and depends on inferring our scenario basd on some firefox prefs
 and the
 }}}
 *based
 {{{
 +  // relationship between the saved list of bridges in abotu:config vs
 the list saved in torrc
 }}}
 *about
 {{{
 +  // builtin default types (obfs4, meek-azure, snowflake, etc) then we
 provide the
 }}}
 comma before "then" (from now on)
 {{{
 +  // "extensions.torlauncher.bridgedb_bridge."" branch. If they match
 *exactly* then we assume
 }}}
 `extensions.torlauncher.bridgedb_bridge.*`
 {{{
 +  // about:config that tells us which scenario we are in so we don't have
 to guess
 }}}
 comma before "so" (from now on)
 {{{
 +    // TODO: put preffered bridge type first in thi slist
 }}}
 *this list
 {{{
 +  // ie: same element in identical order
 }}}
 *i.e. same
 {{{
 +  // clear bridge related firefox prefs
 }}}
 *bridge-related Firefox
 {{{
 +// split on the first colon and any subsequent go into password
 }}}
 rephrase
 {{{
 +  if (colonIndex < 0) {
 +    // we don't log the contents of the potentially password containing
 string
 +    throw new Error ("Invalid USERNAME:PASSWORD string");
 }}}
 "No colon in the string" - that's all what was checked and can be thrown.
 {{{
 +// expects tring in the format: ADDRESS:PORT,ADDRESS:PORT,...
 }}}
 *string
 {{{
 +// expects a '/n' delimited string of bridge string, which we split and
 trim
 }}}
 *bridge strings
 {{{
 +      // TODO: saving to Tor would go in this callback when
 about:preferenes loses focus (ie user switches to another tab or closes)
 }}}
 done?
 {{{
 +  Strings loaded from torbutton, but provide a fallback in case torbutton
 addon not enabled
 }}}
 heh
 {{{
 +    bridgesDescription : getString(null, "Bridges help you to access the
 Tor network in places where Tor is blocked. This is dummy text now, but it
 should explain in plain words what is a bridge and how it can help
 them."),
 }}}
 :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31286#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online