[tbb-bugs] #28196 [Applications/Tor Browser]: about:preferences#general is not properly translated anymore starting with Tor Browser 8.5a4

[Tor Bug Tracker & Wiki]

#28196: about:preferences#general is not properly translated anymore starting with
Tor Browser 8.5a4
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-regression,                      |  Actual Points:
  TorBrowserTeam201811                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:7 acat]:
 > In esr68 the situation is worse, since there are more usages of `tor-
 browser-brand.ftl`, which means more parts of the UI are not localized.
 >
 > I looked a bit how Fluent loads the resources, and wanted to suggest the
 following to solve this issue. We could move `tor-browser-brand.ftl` to
 `toolkit/torproject/torbutton/chrome/locale/*` and localize it there
 (starting with the English version for all locales we support). Then we
 can use the `L10nRegistry.registerSource` to register our own Fluent
 source so that it finds our `tor-browser-brand.ftl` and possibly other
 `*.ftl` resources in the future (see https://searchfox.org/mozilla-
 esr68/rev/baaa20d01cd7e63135c29a5f62717f29581f579f/browser/components/BrowserGlue.jsm#1144
 or https://searchfox.org/mozilla-
 esr68/rev/baaa20d01cd7e63135c29a5f62717f29581f579f/toolkit/components/extensions/Extension.jsm#2474).
 Now `tor-browser-brand.ftl` is identical for the three brands we support
 (alpha, nightly, official), so that would simplify things a bit.
 >
 > Do you think this is an ok plan to solve the issue?

 Yes, thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28196#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online