[tbb-bugs] #30429 [Applications/Tor Browser]: Rebase Tor Browser patches for Firefox ESR 68

[Tor Bug Tracker & Wiki]

#30429: Rebase Tor Browser patches for Firefox ESR 68
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,        |  Actual Points:
  TorBrowserTeam201909R                          |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor44-can
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:67 mcs]:
 > Replying to [comment:66 gk]:
 > > Well, indeed I had forgotten about that. However, why does this issue
 apply to macOS which is the only platform that part of the patch is
 concerned about? I mean we set `LD_LIBRARY_PATH` on Linux with the start
 script, so I see why we ran into #18900 but we don't touch the respective
 env variable on macOS, no?
 >
 > On macOS we do have the `tor` script, although it does not currently
 modify `DYLD_LIBRARY_PATH` in a way that could cause a problem like
 #18900. However, the `strstr()` code is wrong and it seems risky to
 include it given the potential for future problems. Also, none of our
 recent Tor Browser releases have included the `strstr()` code so Kathy and
 I are not comfortable adding it this close to the 9.0 release.

 That's perfectly fine. I am interested to get the reasons for our omission
 right here, though, to make it easier for future readers (both us and
 anybody else) to understand why we did what.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30429#comment:70>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online