[tbb-bugs] #32210 [Applications/Tor Browser]: Hide the "Tor" section in preferences when TOR_SKIP_LAUNCH=1 is set

[Tor Bug Tracker & Wiki]

#32210: Hide the "Tor" section in preferences when TOR_SKIP_LAUNCH=1 is set
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:
                                                 |  pospeselr
     Type:  defect                               |         Status:  closed
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  tbb-9.0-issues, tbb-9.0.1-can,       |  Actual Points:
  TorBrowserTeam201910R                          |
Parent ID:                                       |         Points:  0.2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => closed
 * points:   => 0.2
 * resolution:   => fixed


Comment:

 Replying to [comment:6 pospeselr]:
 > Small patch to hide/disable the tor page in about:preferences when tor-
 launcher does not own the tor daemon (ie when using system tor)
 >
 > tor-browser: https://gitweb.torproject.org/user/richard/tor-
 browser.git/commit/?h=bug_32210

 That's a bit of new code added to different places and I would be
 hesitating just shipping it in 9.0.1. But it seems it's mainly the
 mechanism used to hide Sync if it is disabled. Thus, this seems already
 tested quite a bit. So, this looks good to me and works for me, thanks!

 I put your code into proper fixup commits, though, this time. Please do it
 the next time, too (if there is anything that's worth a fixup commit and
 not a "real" one).

 Applied to `tor-browser-68.2.0esr-9.5-1` (commit
 5d24d4b6873de2da8afa7cba448905522311a4b8) and `tor-
 browser-68.2.0esr-9.0-1` (commit
 a339c6ec84d612d37eb409eca1b36706a89c9486).

 Please add your points.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32210#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online