[tbb-bugs] #32303 [Applications/Tor Browser]: obfs4proxy incompatibility on Android Q

[Tor Bug Tracker & Wiki]

#32303: obfs4proxy incompatibility on Android Q
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-9.0-issues,             |  Actual Points:
  tbb-9.0.1-can, TorBrowserTeam201911            |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 I forgot to mention I pushed a new branch for this. It's on `bug32303_02`.

 I pushed another commit that bumps the go version to `1.12.13` so we pick
 up the latest security patches (I haven't tested a full build with this
 yet).

 GeKo asked if we can exclude the original obfs4proxy binary instead of
 simply overwriting it in the tor-browser build stage. It turns out this is
 an interesting question and reveals I should re-think this patch.

 obfs4proxy comes from [https://github.com/guardianproject/pluto pluto],
 which is imported as a git submodule in `tor-onion-proxy-library`. The
 submodule uses `64faf224a90ec3ef8a806f9ec45c1caffafea768` which was
 commited in October 2018. So, this is a mess. `pluto` is not maintained
 anymore, and now TOPL should use
 https://github.com/guardianproject/AndroidPluggableTransports (with
 obfs4proxy coming from https://gitlab.com/eighthave/goptbundle, which is a
 fork of obfs4proxy). We shouldn't change this in this ticket, however.

 I'll create another branch where we add `obfs4proxy` in the `tor-onion-
 proxy-library` project instead of `tor-browser`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32303#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online