[tbb-bugs] #32259 [Applications/Tor Browser]: Tor Browser fails to start on some Linux systems without libatomic being installed

[Tor Bug Tracker & Wiki]

#32259: Tor Browser fails to start on some Linux systems without libatomic being
installed
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0.1-can,       |  Actual Points:
  TorBrowserTeam201912                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by sysrqb):

 * keywords:  tbb-9.0-issues, tbb-9.0.1-can => tbb-9.0-issues,
     tbb-9.0.1-can, TorBrowserTeam201912


Comment:

 It seems Icecat is still on 60esr, so any older systems that only have
 Icecat (or similar) installed won't have libatomic installed as a
 dependency yet (sigh).

 https://git.savannah.gnu.org/cgit/gnuzilla.git

 `build/autoconf/toolchain.m4`:
 {{{
  92 AC_DEFUN([MOZ_CXX11],
  93 [
  94 dnl Updates to the test below should be duplicated further below for
 the
  95 dnl cross-compiling case.
  96 AC_LANG_CPLUSPLUS
  97 if test "$GNU_CXX"; then
  98     AC_CACHE_CHECK([whether 64-bits std::atomic requires -latomic],
  99         ac_cv_needs_atomic,
 100         dnl x86 with clang is a little peculiar.  std::atomic does not
 require
 101         dnl linking with libatomic, but using atomic intrinsics does,
 so we
 102         dnl force the setting on for such systems.
 103         if test "$CC_TYPE" = "clang" -a "$CPU_ARCH" = "x86" -a
 "$OS_ARCH" = "Linux"; then
 104             ac_cv_needs_atomic=yes
 }}}

 I guess we can either bundle it (as a fallback) or try detecting this at
 run-time and notify the user they should install it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32259#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online