[tbb-bugs] #10760 [Applications/Tor Browser]: Integrate TorButton to TorBrowser core to prevent users from disabling it

[Tor Bug Tracker & Wiki]

#10760: Integrate TorButton to TorBrowser core to prevent users from disabling it
-------------------------------------------------+-------------------------
 Reporter:  Rezonansowy                          |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  AffectsTails, tbb-parity,            |  Actual Points:
  TorBrowserTeam201905, GeorgKoppen201905        |
Parent ID:  #24855                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by anonym):

 Replying to [comment:41 intrigeri]:

 > Replying to [comment:40 mcs]:
 >
 >
 > > I guess I was thinking of the setup mode (where Tor Launcher is
 currently used as a standalone XUL app). In that case, if you use Tor
 Browser, you may not want the Torbutton code doing anything...
 > >
 > >
 >
 > Good catch! Indeed, Tor Launcher as we currently run it has no Torbutton
 extension available. I don't know what would happen if it had.

 First, I don't see why this should be any different than the "vanilla"
 (i.e. non-Tails) Tor Browser, where Torbutton and Tor Launcher are enabled
 at the same time.

 Second, Tails has a third use case for Tor Browser: the Unsafe Browser. It
 has direct Internet access (so users can deal with captive portals to get
 Tor working) and aims to look like a normal Firefox, so I guess we'd still
 want a way to disable Torbutton for it. But if we cannot for some reason
 that's actually not so bad: since we any way have all the Tor Browser
 patches applied it probably distinguishes itself quite a bit from a
 "normal" Firefox already, so adding Torbutton (but with disabled proxying)
 might not make things much worse.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10760#comment:44>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online