[tbb-bugs] #27484 [Applications/Tor Browser]: Onboarding: unintuitive not-navigation buttons, starting with "Circuit Display" / "See My Path"

[Tor Bug Tracker & Wiki]

#27484: Onboarding: unintuitive not-navigation buttons, starting with "Circuit
Display" / "See My Path"
-------------------------------------------------+-------------------------
 Reporter:  dmr                                  |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-8.0-issues, tbb-onboarding, ux-  |  Actual Points:
  team, TorBrowserTeam201903, tbb-8.5-must-      |
  alpha                                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:
     tbb-8.0-issues, tbb-onboarding, ux-team, TorBrowserTeam201903R,
     tbb-8.5-must-alpha
     =>
     tbb-8.0-issues, tbb-onboarding, ux-team, TorBrowserTeam201903, tbb-8.5
     -must-alpha
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:30 mcs]:
 > Replying to [comment:27 gk]:
 > > Looks mostly good. One thing that needs to  get fixed is that your
 code is jumping over the security pane directly to "Experience Tips" if
 clicking on "Go to Security". Moreover, clicking on the respective button
 on the security pane to move forward is doing nothing.
 >
 > Ugh. I am sorry about those problems. We revised the patch to add a new
 `gotoNextTourItem()` function, which makes everything less error-prone.
 Please take a look:
 > https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug27484-02&id=d6319109718b5e2bbd82244bce9baeaaea46f356

 No worries, looks better now. One final thing I noticed while testing:
 What's the purpose of the blue-ish border around the button that shows up
 once I click (mouse-down) on the not-go-to-next-pane-buttons? I guess it's
 meant as a further visual indicator (besides the grey of the button
 getting a bit darker) that the user is currently clicking on/selecting
 that button? I am asking because it behaves differently on different
 panes. For instance, if I click (mouse-down) to check out the security
 settings I see that the button gets darker grey and the border shows up
 and it gets back to normal without the blue border once I actually execute
 the action behind it (mouse-up). However, that does not happen on the
 panes where external sites get loaded. In those cases those sites get
 loaded in a new tab, the grey of the button gets back to the original one,
 but the blue-ish border stays, which is confusing.

 You can see that behavior on the security pane as well if you mouse-down
 on the button but move the mouse cursor from the button and do a mouse-up
 somewhere else: the grey tone resets but the blue border stays.

 I'd say the expected behavior is the blue-ish border follows the behavior
 of the other selected/clicked indicator: if the button gets darker, the
 border shows up, but if the button gets less dark again the border
 vanishes, too.

 (Sorry for the many words, it turned out hard for me to explain the issue
 in english. :) I hope it makes sense, but if not please ping me and we
 sort it out via chat).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27484#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online