[tbb-bugs] #29440 [Applications/Tor Browser]: Update about:tor when Tor Browser is updated

[Tor Bug Tracker & Wiki]

#29440: Update about:tor when Tor Browser is updated
-------------------------------------------------+-------------------------
 Reporter:  antonela                             |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ux-team, tbb-update,                 |  Actual Points:
  TorBrowserTeam201903R, tbb-8.5                 |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:21 mcs]:
 > Replying to [comment:20 gk]:
 > > Do we have a way to just show the "View Changelog" link on the release
 and alpha series where there actually is a Changelog?
 >
 > Good question. We could omit the ChangeLog.txt file from the nightly
 builds and then modify the about:tor code to check that such a file exists
 (and hide the "View Changelog" link if not). But it seems simplest to just
 check the update channel, so we revised our Torbutton patch to take that
 approach. Please test (and review) using the two torbutton patches that
 are on our bug29440-02 branch:
 >
 ​https://gitweb.torproject.org/user/brade/torbutton.git/log/?h=bug29440-02

 Works for me.

 Two final questions (I think :) ):

 1) What's the reason for having
 {{{
 +        m_tb_prefs.clearUserPref(kShouldNotifyPref);
 }}}
 in the Torbutton patch? What is the scenario you are worried about here
 that makes you clearing the user pref?

 2) What is "tor-right" in "include in the tor-right corner" in the
 Torbutton commit message? Did you mean "upper-right"? (If so, what about
 RTL bundles)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29440#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online