[tbb-bugs] #29675 [Applications/Quality Assurance and Testing]: Nightly build should fail if "make fetch" fails

[Tor Bug Tracker & Wiki]

#29675: Nightly build should fail if "make fetch" fails
-------------------------------------------------+-------------------------
     Reporter:  boklm                            |      Owner:  cypherpunks
         Type:  defect                           |     Status:  new
     Priority:  Medium                           |  Milestone:
    Component:  Applications/Quality Assurance   |    Version:
  and Testing                                    |   Keywords:
     Severity:  Normal                           |  TorBrowserTeam201903
Actual Points:                                   |  Parent ID:
       Points:                                   |   Reviewer:
      Sponsor:                                   |
-------------------------------------------------+-------------------------
 We run `make fetch` during the nightly builds to fetch the latest commits
 before starting the build. However we ignore the exit code from `make
 fetch`, so if there an error in the middle of fetching, then we build with
 old commits.

 Instead we should make the build fail if there was an error in `make
 fetch`, so we can know there was something wrong and can fix it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29675>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online