[tbb-bugs] #10760 [Applications/Tor Browser]: Integrate TorButton to TorBrowser core to prevent users from disabling it

[Tor Bug Tracker & Wiki]

#10760: Integrate TorButton to TorBrowser core to prevent users from disabling it
-------------------------------------------------+-------------------------
 Reporter:  Rezonansowy                          |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  AffectsTails, tbb-parity, ux-team,   |  Actual Points:
  TorBrowserTeam201906, GeorgKoppen201906        |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:53 acat]:
 > > with the corresponding ones from DTD in securityLevel.js
 (​https://github.com/acatarineu/tor-browser/commit/30429+1).
 > Sorry, this was not the right commit implementing this. The duplicated
 translations removal is https://github.com/acatarineu/tor-
 browser/commit/6647e87dc1ed59c5b39e8618bf8753d1d8423343,

 Where does it remove the duplicated translations in that commit? The
 general approach looks good to me, nice find. I think we should get rid of
 all `getString()` calls while we are at it and make sure that everything
 we need is available both for desktop and mobile, hence in the .dtd file
 (we have #24653 for the localization parity part which could be solved
 while redoing this part).

 We should think as well more general about a mechanism of avoiding
 duplicated translations as I am not sure whether the hack you found is
 applicable in more than the sec-settings situation.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10760#comment:66>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online