[tbb-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, TBA-a3,                  |  Actual Points:
  TorBrowserTeam201902R                          |
Parent ID:  #27609                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 Have you seen these build errors. They're obviously coming form proguard,
 but i haven't started comparing Orbot's proguard file(s) with tor-android-
 service's yet.

 {{{
  1:10.37 Note: the configuration refers to the unknown class
 'com.google.android.gms.common.annotation.KeepName'
  1:10.37 Note: the configuration refers to the unknown class
 'com.google.android.gms.common.annotation.KeepName'
  1:10.38 Note: the configuration refers to the unknown class
 'okhttp3.internal.publicsuffix.PublicSuffixDatabase'
 [...]
  1:10.64 Warning:
 com.msopentech.thali.toronionproxy.OnionProxyManagerEventHandler: can't
 find superclass or interface net.freehaven.tor.control.EventHandler
  1:10.64 Warning: org.torproject.android.service.TorEventHandler: can't
 find superclass or interface net.freehaven.tor.control.EventHandler
  1:10.94 Warning: com.msopentech.thali.toronionproxy.BaseEventBroadcaster:
 can't find referenced class org.slf4j.Logger
  1:10.94 Warning: com.msopentech.thali.toronionproxy.BaseEventBroadcaster:
 can't find referenced class org.slf4j.Logger
 [...]
  1:10.95 Warning: com.msopentech.thali.toronionproxy.OnionProxyContext:
 can't find referenced class org.slf4j.Logger
  1:10.95 Warning: com.msopentech.thali.toronionproxy.OnionProxyContext:
 can't find referenced class org.slf4j.LoggerFactory
 [...]
  1:11.22 Warning: org.torproject.android.service.TorService: can't find
 referenced class
 com.msopentech.thali.android.toronionproxy.AndroidOnionProxyManager
  1:11.22 Warning: org.torproject.android.service.TorService: can't find
 referenced class
 com.msopentech.thali.android.toronionproxy.AndroidOnionProxyManager
  1:11.22 Warning: org.torproject.android.service.TorService: can't find
 referenced class
 com.msopentech.thali.android.toronionproxy.AndroidOnionProxyManager
 [...]
  1:11.40 Note: com.google.android.exoplayer2.DefaultRenderersFactory:
 can't find dynamically referenced class
 com.google.android.exoplayer2.ext.vp9.LibvpxVideoRenderer
 [...]
  1:12.84 Note: there were 16 references to unknown classes.
  1:12.84       You should check your configuration for typos.
  1:12.84
 (http://proguard.sourceforge.net/manual/troubleshooting.html#unknownclass)
  1:12.84 Note: there were 11 unkept descriptor classes in kept class
 members.
  1:12.84       You should consider explicitly keeping the mentioned
 classes
  1:12.84       (using '-keep').
  1:12.84
 (http://proguard.sourceforge.net/manual/troubleshooting.html#descriptorclass)
  1:12.84 Note: there were 1 library classes explicitly being kept.
  1:12.84       You don't need to keep library classes; they are already
 left unchanged.
  1:12.85
 (http://proguard.sourceforge.net/manual/troubleshooting.html#libraryclass)
  1:12.85 Note: there were 12 unresolved dynamic references to classes or
 interfaces.
  1:12.85       You should check if you need to specify additional program
 jars.
  1:12.85
 (http://proguard.sourceforge.net/manual/troubleshooting.html#dynamicalclass)
  1:12.85 Warning: there were 83 unresolved references to classes or
 interfaces.
  1:12.87          You may need to add missing library jars or update their
 versions.
  1:12.87          If your code works fine without the missing classes, you
 can suppress
  1:12.87          the warnings with '-dontwarn' options.
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29080#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online