[tbb-bugs] #28685 [Applications/Tor Browser]: Tor Browser for Android needs a more dynamic Build ID

[Tor Bug Tracker & Wiki]

#28685: Tor Browser for Android needs a more dynamic Build ID
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm, TBA-a3,         |  Actual Points:
  TorBrowserTeam201902                           |
Parent ID:  #28708                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TBA-a3, TorBrowserTeam201902R => tbb-
     mobile, tbb-rbm, TBA-a3, TorBrowserTeam201902
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:10 boklm]:
 > I pushed a patch in branch `bug_28685_v3` using the Tor Browser version
 to compute a `MOZ_BUILD_DATE`, instead of the firefox version:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_28685_v3&id=9d6d3f15319cfaf2efdf5677e1e2e9cce022e509
 >
 > With Tor Browser 8.0.6 and Firefox 60.4.0, the build id was
 20190204050101.
 >
 > With this change the build id would be:
 > {{{
 > $ ./projects/firefox/get-moz-build-date 2019 8.0.7
 > export MOZ_BUILD_DATE=20190302080101
 > $ ./projects/firefox/get-moz-build-date 2019 8.5a9
 > export MOZ_BUILD_DATE=20190306100101
 > $ ./projects/firefox/get-moz-build-date 2019 8.5a10
 > export MOZ_BUILD_DATE=20190306110101
 > $ ./projects/firefox/get-moz-build-date 2019 8.5
 > export MOZ_BUILD_DATE=20190307010101
 > $ ./projects/firefox/get-moz-build-date 2019 8.5.1
 > export MOZ_BUILD_DATE=20190307020101
 > }}}

 We shipped 8.0.6 with 60.5.1esr, no? It seems we should adapt the comment
 in the script accordingly.

 The new scheme makes the calculation save until Tor Browser 18, if I see
 this correctly. That's okay for me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28685#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online