[tbb-bugs] #29572 [Applications/Tor Browser]: Fetching latest commits fails with older git versions when building testbuilds

[Tor Bug Tracker & Wiki]

#29572: Fetching latest commits fails with older git versions when building
testbuilds
--------------------------------------+--------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-rbm                   |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by boklm):

 The issue seems to be that we are on a branch while we do the `git fetch`.

 But we are supposed to do a `git checkout --detach` when we are on a
 branch:
 {{{
         my ($ref, undef, $success) = capture_exec('git', 'symbolic-ref',
 'HEAD');
         chomp $ref;
         if ($success && -e ".git/$ref") {
             system('git', 'checkout', '-q', '--detach') == 0
                 || exit_error "Error running git checkout --detach";
         }
 }}}

 Maybe the test to see if we are on a branch is not working?

 To check that, you can go to the directory `git_clones/tor` and run:
 {{{
  git symbolic-ref HEAD
 }}}
 And check that the output from this command exist in `.git`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29572#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online