[tbb-bugs] #28822 [Applications/Tor Browser]: re-implement desktop onboarding for ESR 68

[Tor Bug Tracker & Wiki]

#28822: re-implement desktop onboarding for ESR 68
--------------------------------------------+------------------------------
 Reporter:  mcs                             |          Owner:  tbb-team
     Type:  defect                          |         Status:
                                            |  needs_revision
 Priority:  Medium                          |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201908  |  Actual Points:
Parent ID:  #30429                          |         Points:
 Reviewer:                                  |        Sponsor:
                                            |  Sponsor44-can
--------------------------------------------+------------------------------
Changes (by gk):

 * keywords:  ff68-esr, TorBrowserTeam201908R => ff68-esr,
     TorBrowserTeam201908
 * status:  needs_review => needs_revision


Comment:

 Okay, I took the commits from your `30429+9` and here are my comments:

 ea5f8c2c9ccc0130944f05a6e31ebb2a9322041c - I think it's mostly good. Two
 things:
 {{{
 +const {Services}
 }}}
 I think we settled for space between name and braces in Torbutton? Would
 be good
 here as well.
 {{{
 +       @$(MAKE) -C ../extensions/onboarding/locales chrome AB_CD=$*
 }}}
 It's really just one level up here, right? While all the other items are
 two
 levels up?

 1c9eb3993c5b505c0894b13634b09690bfb97791 - not okay (not sure about the
 changed `onboarding-overlay-button` but we'll see I guess while testing)

 The images are the wrong ones. We want to have those from #30560.

 6f05a139b387c072a63bfae3a086aee2cee95875 - okay
 e19e128476f48278911656db735739f0526f12ce - not okay
 {{{
 -/* The primary button gets the same color as the customize button. */
 }}}
 in `browser/themes/shared/UITour.inc.css` is missing

 742fccfcbb7a19ba9daee44335e9962639773d13 - not okay
 {{{
 -  OnboardingTelemetry:
 "resource://onboarding/modules/OnboardingTelemetry.jsm",
 }}}
 in `browser/extensions/onboarding/bootstrap.js` is missing

 aeb0b6678e61fd282825610ca29a225eb0991281 - I think this is okay, but are
 we affected by https://bugzilla.mozilla.org/show_bug.cgi?id=1498378?

 I'll take the patches, though, for `tor-browser-68.1.0esr-9.0-1`, so
 please provide fixups for the issues above based on that one. (I am about
 to rebase and push it to `tor-browser`).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28822#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online