[tbb-bugs] #10760 [Applications/Tor Browser]: Integrate TorButton to TorBrowser core to prevent users from disabling it

[Tor Bug Tracker & Wiki]

#10760: Integrate TorButton to TorBrowser core to prevent users from disabling it
-------------------------------------------------+-------------------------
 Reporter:  Rezonansowy                          |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  AffectsTails, tbb-parity, ux-team,   |  Actual Points:
  TorBrowserTeam201908R, tbb-9.0-must-nightly,   |
  TorBrowserTeam201908, GeorgKoppen201908        |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by acat):

 Ok, I just realized I made a big/stupid mistake here, I'm sorry :(. At
 some point I looked at what I thought was the latest branch (`10760`) and
 saw that it was missing the `Remove nsISupports from
 ChromeUtils.generateQI` changes, so pushed a new `10760+1` which overwrote
 the actual latest branch (which I had missed), so all the changes
 addressing the review comments got lost.

 Anyway, I recovered the original `10760+1` branch, which is now at
 https://github.com/acatarineu/torbutton/commits/10760+2. I tried merging
 with torbutton 2.2.1, and there were some conflicts but just due to some
 removed files.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10760#comment:83>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online