[tbb-bugs] #30326 [Applications/Tor Browser]: Remove yasm from the list of dependencies for the firefox android build

[Tor Bug Tracker & Wiki]

#30326: Remove yasm from the list of dependencies for the firefox android build
-------------------------------------------+--------------------------
 Reporter:  boklm                          |          Owner:  tbb-team
     Type:  task                           |         Status:  new
 Priority:  Medium                         |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201904  |  Actual Points:
Parent ID:                                 |         Points:
 Reviewer:                                 |        Sponsor:
-------------------------------------------+--------------------------

Comment (by boklm):

 I made a patch for this in branch `bug_30326`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_30326&id=d5be2bbbae4709b42d6520b5b632bf10904e3268

 A build for android-armv7 was successful with this patch. However the
 build for android-x86 fails with:
 {{{
  0:06.96 checking for Android lint classpath...  /var/tmp/dist/android-
 toolchain/android-sdk-linux/tools/lib/lint-26.0.0-dev.jar /var/tmp/dist
 /android-toolchain/android-sdk-linux/tools/lib/lint-checks-26.0.0-dev.jar
 /var/tmp/dist/android-toolchain/android-sdk-
 linux/tools/lib/sdklib-26.0.0-dev.jar /var/tmp/dist/android-toolchain
 /android-sdk-linux/tools/lib/repository-26.0.0-dev.jar /var/tmp/dist
 /android-toolchain/android-sdk-linux/tools/lib/common-26.0.0-dev.jar
 /var/tmp/dist/android-toolchain/android-sdk-linux/tools/lib/lint-
 api-26.0.0-dev.jar /var/tmp/dist/android-toolchain/android-sdk-
 linux/tools/lib/manifest-merger-26.0.0-dev.jar
  0:06.98 configure: error: yasm is a required build tool for this
 architecture when webm is enabled. You may either install yasm or
 --disable-webm (which disables the WebM video format). See
 https://developer.mozilla.org/en/YASM for more details.
  0:06.99 DEBUG: <truncated - see config.log for full output>
  0:06.99 DEBUG: configure:10347: checking for zipalign
  0:06.99 DEBUG: configure:10399: checking for Android platform-tools
  0:06.99 DEBUG: configure:10409: checking for adb
  0:06.99 DEBUG: configure:10461: checking for Android tools
  0:06.99 DEBUG: configure:10471: checking for emulator
  0:06.99 DEBUG: configure:10539: checking for Android lint classpath
  0:06.99 DEBUG: configure:11315: /var/tmp/dist/android-toolchain/android-
 ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/clang -std=gnu99
 --target=i386-linux-android -c -fno-short-enums -fno-exceptions   -fno-
 strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno
 -Qunused-arguments -isystem /var/tmp/dist/android-toolchain/android-
 ndk/platforms/android-16/arch-x86/usr/include -isystem /var/tmp/dist
 /android-toolchain/android-ndk/platforms/android-16/arch-x86/usr/include
 -gcc-toolchain /var/tmp/dist/android-toolchain/android-
 ndk/toolchains/x86-4.9/prebuilt/linux-x86_64 -D__ANDROID_API__=16
 conftest.c 1>&5
  0:06.99 DEBUG: In file included from configure:11309:
  0:06.99 DEBUG: /usr/include/linux/ethtool.h:1220:8: error: fields must
 have a constant size: 'variable length array in structure' extension will
 never be supported
  0:06.99 DEBUG:         __u32
 queue_mask[__KERNEL_DIV_ROUND_UP(MAX_NUM_QUEUE, 32)];
  0:06.99 DEBUG:                 ^
  0:06.99 DEBUG: 1 error generated.
  0:06.99 DEBUG: configure: failed program was:
  0:06.99 DEBUG: #line 11308 "configure"
  0:06.99 DEBUG: #include "confdefs.h"
  0:06.99 DEBUG: #include <linux/ethtool.h>
  0:06.99 DEBUG: int main() {
  0:06.99 DEBUG:  struct ethtool_cmd cmd; cmd.speed_hi = 0;
  0:06.99 DEBUG: ; return 0; }
  0:06.99 DEBUG: configure: error: yasm is a required build tool for this
 architecture when webm is enabled. You may either install yasm or
 --disable-webm (which disables the WebM video format). See
 https://developer.mozilla.org/en/YASM for more details.
  0:06.99 ERROR: old-configure failed
  0:07.01 *** Fix above errors and then restart with\
  0:07.01                "/usr/bin/make -f client.mk build"
  0:07.01 client.mk:146: recipe for target 'configure' failed
  0:07.01 make: *** [configure] Error 1
 }}}

 Looking at `old-configure.in`, it seems we need yasm for all x86 builds.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30326#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online