[tbb-bugs] #29981 [Applications/Tor Browser]: Add option to build without using containers

[Tor Bug Tracker & Wiki]

#29981: Add option to build without using containers
-------------------------------------------+--------------------------
 Reporter:  boklm                          |          Owner:  tbb-team
     Type:  task                           |         Status:  new
 Priority:  Medium                         |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201904  |  Actual Points:
Parent ID:                                 |         Points:
 Reviewer:                                 |        Sponsor:
-------------------------------------------+--------------------------

Comment (by boklm):

 Using the patch from branch `bug_29981_v3` I have been able to do a build
 without containers:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_29981_v3&id=ab3c5d96be66d09d4dc98be385e495244bef48af

 The apk I got does not match the one built using container, but the only
 difference is:
 {{{
 --- tor-browser-8.5a10-android-armv7-multi-qa.apk
 +++ ../../testbuild/tor-browser-8.5a10-android-armv7-multi-qa.apk
 ├── zipinfo {}
 │ @@ -1502,13 +1502,13 @@
 │  -rwxr-xr-x  2.0 unx     5596 b- defX 10-Jan-01 00:00 lib/armeabi-v7a
 /libplugin-container.so
 │  -rw-r--r--  2.0 unx      382 b- defX 10-Jan-01 00:00 application.ini
 │  -rw-r--r--  2.0 unx       32 b- defX 10-Jan-01 00:00 package-name.txt
 │  -rw-r--r--  2.0 unx      795 b- defX 10-Jan-01 00:00 ua-update.json
 │  -rw-r--r--  2.0 unx       48 b- defX 10-Jan-01 00:00 platform.ini
 │  -rw-r--r--  2.0 unx       97 b- defX 10-Jan-01 00:00 removed-files
 │  -rw-r--r--  2.0 unx 10641927 b- stor 10-Jan-01 00:00 assets/omni.ja
 │ --rw-r--r--  3.0 unx   502590 b- defN 00-Jan-01 00:00
 assets/distribution/extensions/{73a6fe31-595d-460b-a920-fcc0f8843232}.xpi
 │  -rw-r--r--  3.0 unx  1765652 b- defN 00-Jan-01 00:00
 assets/distribution/extensions/https-everywhere-eff at eff.org.xpi
 │ +-rw-r--r--  3.0 unx   502590 b- defN 00-Jan-01 00:00
 assets/distribution/extensions/{73a6fe31-595d-460b-a920-fcc0f8843232}.xpi
 │  -rw----     2.0 fat   144465 b- defN 10-Jan-01 00:00 META-
 INF/ANDROIDQ.SF
 │  -rw----     2.0 fat     1194 b- defN 10-Jan-01 00:00 META-
 INF/ANDROIDQ.RSA
 │  -rw----     2.0 fat   144360 b- defN 10-Jan-01 00:00 META-
 INF/MANIFEST.MF
 │  1512 files, 58292874 bytes uncompressed, 44899152 bytes compressed:
 23.0%
 }}}

 I think the cause of this is this line in `projects/tor-
 browser/build.android`:
 {{{
 zip -r -X $apk $ext_dir
 }}}

 Which is not adding the extensions to the .apk in a sorted order.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29981#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online