[tbb-bugs] #29768 [Applications/Tor Browser]: Introduce new features to users in Tor Browser
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Apr 4 14:07:32 UTC 2019
#29768: Introduce new features to users in Tor Browser
-------------------------------------------------+-------------------------
Reporter: antonela | Owner: tbb-
| team
Type: defect | Status:
| needs_review
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201903R, tbb-8.5 | Actual Points:
-must-alpha, TorBrowserTeam201904 |
Parent ID: #25658 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by gk):
Replying to [comment:31 mcs]:
> Okay, here is our torbutton patch (add new strings):
>
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug29768-01&id=9d7c1081105eb3858f6654daa31202d4bac1d84f
>
> And here is our tor-browser patch (make all the new stuff work):
> https://gitweb.torproject.org/user/brade/tor-
browser.git/commit/?h=bug29768-01&id=e4a163b58530f37b7f292fe49ad7b882b2f046d0
>
> Adding the attention-grabbing dot took some work but it seems
worthwhile. We ended up using a variation of the third animation that
Dunqan suggested in comment:4 (a simple pulsating "dot" that stops
animating after 14 seconds). Kathy and I think it looks good without being
too annoying. Once we have a new nightly build everyone should take a look
at it. You can force the 8.5 update tour to be displayed by opening the
browser, using about:config to set `browser.onboarding.tourset-version` to
`2` (instead of the new default value of `3`), and then restarting the
browser.
Looks good to me. I merged the Torbutton patch to `master` (commit
9d7c1081105eb3858f6654daa31202d4bac1d84f) and the browser patch to `tor-
browser` (commit e4a163b58530f37b7f292fe49ad7b882b2f046d0).
For anyone testing that in, say, nightly builds the pref to actually set
tp `2` is `browser.onboarding.seen-tourset-version`.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29768#comment:34>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list