[tbb-bugs] #27905 [Applications/Tor Browser]: many occurrences of "Firefox" in about:preferences

[Tor Bug Tracker & Wiki]

#27905: many occurrences of "Firefox" in about:preferences
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  mcs
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:                                       |  Actual Points:
  ff60-esr,tbb-8.0-issues,TorBrowserTeam201809R  |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mcs):

 * keywords:  ff60-esr,tbb-8.0-issues,TorBrowserTeam201809 =>
     ff60-esr,tbb-8.0-issues,TorBrowserTeam201809R
 * status:  assigned => needs_review


Comment:

 Here is a patch:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug27905-01&id=f8bdd93d75fb9d74ffacf4b0524c50a9026ceb95

 For some reason Mozilla made it possible for the brand short name to be
 localized, and in fact the ESR60 language packs include a brand.ftl file
 (all of which probably have `-brand-short-name = Firefox`, so what's the
 point?) We worked around this problem by adding a `tor-browser-brand.ftl`
 file which is used instead of `brand.ftl`.

 Note that there are two items with about:preferences that are not fixed by
 this patch:
 1. There is an occurrence of `Firefox` within the `Change Block List`
 "dialog" which is not easily fixed because it is hard-coded within a
 localizable string. This was fixed in Firefox 61 but may not be easy to
 backport; see https://hg.mozilla.org/mozilla-central/rev/8ebf84e9825d
 2. The `Data Collection and Use" section also includes some hard-coded
 occurrences of `Firefox`. But I think we should hide that section anyway;
 see #27909.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27905#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online