[tbb-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Sep 4 18:10:07 UTC 2018
#26697: Add Android toolchain
-------------------------------------------------+-------------------------
Reporter: boklm | Owner: tbb-
| team
Type: task | Status:
| needs_revision
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, tbb-mobile, | Actual Points:
TorBrowserTeam201809R |
Parent ID: #26693 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by boklm):
* status: needs_review => needs_revision
Comment:
Replying to [comment:3 sisbell]:
> commit: https://github.com/sisbell/tor-browser-
build/commit/3ac1fe9c44a1ec20946896824cb06523e7370ef7
I did not try a build yet with this commit, but here are some first
comments:
- the format of the commit subjects should be `Bug XXXX: description of
the commit`. So in this case, it should be `Bug 26697: Add Android
toolchain`
- it seems the `var/setup` in `projects/android-toolchain/config` is
wrong:
{{{
setup: |
mkdir -p /var/tmp/dist
unzip sdk.zip
}}}
The zip file will be extracted in the current directory instead of
`/var/tmp/dist`. And `sdk.zip` is probably not the correct filename.
Instead `$rootdir/[% c("compiler_tarfile") %]` should be used as the
filename.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26697#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list