[tbb-bugs] #27443 [Applications/Tor Browser]: Update Firefox RBM config and build for Android

[Tor Bug Tracker & Wiki]

#27443: Update Firefox RBM config and build for Android
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-mobile,                 |  Actual Points:
  TorBrowserTeam201810                           |
Parent ID:  #26693                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by boklm):

 Replying to [comment:8 sisbell]:
 > I made some additional fixes.

 * Could you push your new revisions to new branches instead of force-
 pushing on the same branch? This makes it harder to see what was changed
 since the previous revision.
 * Could you also rebase it on current master? It is currently based on a
 commit that is more than 2 months old.
 * I am not sure I understand what those lines are doing. This seems to be
 creating a `gcc -> gcc` symlink?
 {{{
 +[% IF c('var/android') %]
 +  ln -s gcc $ANDROID_NDK_HOME/arm/bin/gcc
 +[% END -%]
 }}}
 * could you add a comment explaining why we need the
 `projects/firefox/gradle.patch`? Maybe this is something we want to patch
 in `tor-browser.git` directly?
 * there is a trailing whitespace in `projects/firefox/mozconfig-android-
 armv7` at the end of the `--with-android-sdk=` line
 * do we really need our own build of binutils for the android build of
 firefox?
 * commit `6af47ae272b6098eac1c9ba886ff9ab04e3fc441` seems to have the
 wrong bug number
 * could you explain why we need `projects/firefox/android.patch`? It seems
 to be removing some code behind `#if defined(GP_OS_linux)` and forcing use
 of the code previously behind `#elif defined(GP_OS_android)`. Shouldn't
 `defined(GP_OS_linux)` be false and `defined(GP_OS_android)` be true in
 the android build?


 >
 >
 >
 > Some additional minor cleanup items left.
 >
 >  1. What to include in dist package. Just apks?

 I think `projects/firefox/build` can just copy the generated apk files,
 for now. Later we will probably need to repackage them in `projects/tor-
 browser/build` to include other components such as tor and Orbot, but this
 can be done later.

 >
 >
 >  1. Use a new var to indicate if mar tools should be built (rather than
 platform var)

 Don't we want to build mar files for android too? Or is the firefox
 updater based on mar files not working on android?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27443#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online