[tbb-bugs] #28002 [Applications/Tor Browser]: The precomplete file in en-US Windows installer is incorrect

[Tor Bug Tracker & Wiki]

#28002: The precomplete file in en-US Windows installer is incorrect
--------------------------------------------+--------------------------
 Reporter:  boklm                           |          Owner:  tbb-team
     Type:  defect                          |         Status:  closed
 Priority:  Medium                          |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201810R  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+--------------------------

Comment (by mcs):

 Replying to [comment:4 boklm]:
 > I was expecting the first partial update to fail, as the `precomplete`
 file installed is different from the one included in the mar file used to
 generate the incremental, so patching that file would fail. But if I
 understand the `check_for_forced_update` function correctly in `tools
 /update-packaging/make_incremental_update.sh`, the `precomplete` file is
 always updated as a full update instead of a patch. So this bug should
 have no impact.

 That is correct. There might be a small impact during full updates since
 the contents of the precomplete file are used to remove old files, e.g.,
 if a file is removed from the browser package between version 8.0.2 and
 8.0.3 and a full update is used to make the update, precomplete is used to
 remove all of the old files. This avoids old, outdated files from
 remaining after an update. That said, I am not sure what was missing from
 the precomplete file we used to ship (before this ticket was fixed).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28002#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online