[tbb-bugs] #13373 [Applications/Tor Browser]: Get rid of LD_LIBRARY_PATH and use a relative RPATH/RUNPATH in Linux bundles

[Tor Bug Tracker & Wiki]

#13373: Get rid of LD_LIBRARY_PATH and use a relative RPATH/RUNPATH in Linux
bundles
--------------------------------------+--------------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  enhancement               |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-rbm                   |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-rbm, TorBrowserTeam201810R => tbb-rbm


Comment:

 Looking at the patch we are still using `LD_LIBRARY_PATH`? But the plan
 was to get rid of it. What is preventing us from doing so (this needs at
 least some commenting)?

 Are we good when updating from a Tor Browser version using the
 `LD_LIBRARY_PATH` approach to the new one implemented in this bug?

 Please use a separate commit for the snowflake issue with the respective
 bug number.

 Re the selfrando parts. I think using `chrpath` to get rid of the
 selfrando related bits seems like a good idea, as we are currently doing.
 Thus, just the `$ORIGIN/TorBrowser/Tor` should remain.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13373#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online