[tbb-bugs] #27905 [Applications/Tor Browser]: many occurrences of "Firefox" in about:preferences

[Tor Bug Tracker & Wiki]

#27905: many occurrences of "Firefox" in about:preferences
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  mcs
     Type:  defect                               |         Status:  closed
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  ff60-esr, tbb-8.0-issues,            |  Actual Points:
  TorBrowserTeam201810R, tbb-backport            |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => closed
 * keywords:  ff60-esr, tbb-8.0-issues, TorBrowserTeam201810R => ff60-esr,
     tbb-8.0-issues, TorBrowserTeam201810R, tbb-backport
 * resolution:   => fixed


Comment:

 Replying to [comment:1 mcs]:
 > Here is a patch:
 > https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug27905-01&id=f8bdd93d75fb9d74ffacf4b0524c50a9026ceb95
 >
 > For some reason Mozilla made it possible for the brand short name to be
 localized, and in fact the ESR60 language packs include a brand.ftl file
 (all of which probably have `-brand-short-name = Firefox`, so what's the
 point?) We worked around this problem by adding a `tor-browser-brand.ftl`
 file which is used instead of `brand.ftl`.
 >
 > Note that there are two items with about:preferences that are not fixed
 by this patch:
 > 1. There is an occurrence of `Firefox` within the `Change Block List`
 "dialog" which is not easily fixed because it is hard-coded within a
 localizable string. This was fixed in Firefox 61 but may not be easy to
 backport; see https://hg.mozilla.org/mozilla-central/rev/8ebf84e9825d

 Could you file a ticket for that so we have it on our `ff68-esr` radar (I
 agree, the backport effort might not be worth it in this case)

 > 2. The `Data Collection and Use" section also includes some hard-coded
 occurrences of `Firefox`. But I think we should hide that section anyway;
 see #27909.

 Sounds good.

 The patch looks good to me. I cherry-picked it to `tor-
 browser-60.2.1esr-8.5-1` (commit
 482dd99c9507ae456578ba1fedfb4cc714e87ecc). Marking it for a possible
 backport.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27905#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online