[tbb-bugs] #28051 [Applications/Tor Browser]: Build Orbot into TBA

[Tor Bug Tracker & Wiki]

#28051: Build Orbot into TBA
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  sysrqb
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tba-a2,                  |  Actual Points:
  TorBrowserTeam201811                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 Replying to [comment:31 sysrqb]:
 > Replying to [comment:30 gk]:
 > >
 > > 653a7f6f119b26dd7920ea802435d3b3163ec19d - okay (what's the reason we
 suddenly need to cast them?)
 > >
 >
 > I get an error like:
 >
 > {{{
 >
 > > Task :app:compileFullpermReleaseJavaWithJavac FAILED
 >
 /home/android/orbot/app/src/main/java/org/torproject/android/ui/AppManagerActivity.java:62:
 error: incompatible types: View cannot be converted to GridView
 >         listApps = findViewById(R.id.applistview);
 >
 > }}}
 >
 > I don't know the exact reason, but this is either directly or indirectly
 caused by changing the support library from version 27.1.1 to 23.4.0. I
 thought this was related to the API/SDK version we were targeting or
 compiling, but changing those doesn't affect whether or not we receive a
 compile-time error. I only see this when changing the version of
 `implementation 'com.android.support:design:23.4.0'` in app/build.gradle.
 >

 Also, just so it's clear, the
 [https://developer.android.com/reference/android/app/Activity.html#findViewById(int)
 Android documentation] says:

 {{{
 Note: In most cases -- depending on compiler support -- the resulting view
 is automatically
 cast to the target class type. If the target class type is unconstrained,
 an explicit cast
 may be necessary.
 }}}

 I'm guessing additional compiler support is enabled when a newer support
 library is used - but that's only a guess.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28051#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online