[tbb-bugs] #27977 [Applications/Tor Browser]: Build Orbot with rbm/tor-browser-build

[Tor Bug Tracker & Wiki]

#27977: Build Orbot with rbm/tor-browser-build
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-mobile,                 |  Actual Points:
  TorBrowserTeam201811R, TBA-a2                  |
Parent ID:  #26693                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 Replying to [comment:40 gk]:
 > Replying to [comment:39 sisbell]:
 > > Looks like your setup is out of sync (or perhaps something wasn't
 checked in). This was recently added to 28051_3. It adds the custom
 notification that your build log is saying its missing.
 > >
 > >
 > > {{{
 > > commit 4fd4234b10ee9af9dbd7e0d217135247f976015d
 > > Author: Matthew Finkel <Matthew.Finkel at gmail.com>
 > > Date:   Thu Nov 22 05:06:08 2018 +0000
 > >
 > >     Bug 28051 - Use the custom notification compat impl
 > >
 > > }}}
 >
 > Yeah, that's been my first intuition as well but the patch does get
 applied properly. From the build log that is failing:
 > {{{
 > patching file mobile/android/base/java/org/mozilla/gecko/GeckoApp.java
 > Hunk #2 succeeded at 598 (offset 4 lines).
 > Hunk #3 succeeded at 1217 (offset 11 lines).
 > patching file
 mobile/android/base/java/org/mozilla/gecko/GeckoApplication.java
 > patching file
 mobile/android/base/java/org/mozilla/gecko/LauncherActivity.java
 > patching file
 mobile/android/base/java/org/mozilla/gecko/notifications/NotificationClient.java
 > patching file
 mobile/android/base/java/org/mozilla/gecko/notifications/NotificationHelper.java
 > }}}
 > And checking the patch again which I apply, it has all the notifications
 changes as well from commit 4fd4234b10ee9af9dbd7e0d217135247f976015d. So,
 this is weird...

 I'm not seeing NotificationBuilderCompat.java when I search the project. I
 don't see the class added in commit
 abc79c5c2a2ec8cdbfe3f167e1ae50a4b6a6cbdb So we need to locate this missing
 file. My guess is it should have been checked in with the commit but
 wasn't.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27977#comment:41>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online