[tbb-bugs] #27977 [Applications/Tor Browser]: Build Orbot with rbm/tor-browser-build

[Tor Bug Tracker & Wiki]

#27977: Build Orbot with rbm/tor-browser-build
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-mobile,                 |  Actual Points:
  TorBrowserTeam201811, TBA-a2                   |
Parent ID:  #26693                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 Replying to [comment:11 gk]:
 > Replying to [comment:8 sisbell]:
 > > Changes (android-1113)
 > >
 > >  * Added gradle dependencies to list (similar to firefox)
 > >  * Upgrade gradle to 4.4 (it appears there is one plugin that needs
 4.4)
 >
 > I tried igt0's patch for #25013 on top of that today and suddenly the
 Firefox build is busted. It's failing in the configure script complaining
 that gradle needs to be executable.
 >
 > I have not looked closer at the commit but I suspect that's just caused
 by bumping the gradle version? That said, looking at the changes to the
 android-toolchain project: what's the reason for `--api 16` now instead of
 `--api 26` or is that a typo?
 >
 I should add in a comment in build file to explain this line. This is
 assembling the NDK build tools for API 16. Our minSdkVersion is also 16,
 meaning this is the lowest platform level we support for the entire apk.
 the targetSdkVersion is 26, meaning we have tested up to 26 so the device
 platform will not apply any compatibility behaviors to make it run on 26
 or below. But it will for 27+.

 So the --api 16 we are using here is to assemble the NDK to build
 projects/rust. The --with-android-version field in the mozconfig is what
 firefox uses for its build. These should match (I know they are mismatched
 in the current branch due to testing)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27977#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online